Fix rebinding imports #2312
Merged
Fix rebinding imports #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerboat9
force-pushed
the
fix-import-as
branch
2 times, most recently
from
8772968 to
62f5051
Compare
CohenArthur
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Import resolution needs to happen during early name resolution and macro expansion, so not within the "late" name resolver that is rust-ast-resolve-item.cc. At the moment the system is a bit of a mess and we are working on reimplementing our name resolution from scratch - I'll send the first PR soon, and it'd be great to have your contributions on it :)
powerboat9
force-pushed
the
fix-import-as
branch
2 times, most recently
from
4785b56 to
e7c6e69
Compare
|
@powerboat9 are you interested in updating/rebasing this PR? I think it would still be worth it to have rebinding imports fixed for the existing name resolution algorithm, since NR 2.0 is taking longer than I planned (due to me not having time to work on it at all, sorry about that) |
gcc/rust/ChangeLog: * resolve/rust-ast-resolve-item.cc (flatten_glob): Use Import class. (flatten_rebind): Likewise. (flatten_list): Likewise. (flatten): Likewise. (flatten_use_dec_to_paths): Likewise. (flatten_use_dec_to_imports): Likewise. (ResolveItem::visit): Likewise. (Import::add_prefix): New. (rust_flatten_nested_glob): Adjust test. (rust_flatten_glob): Likewise. (rust_flatten_rebind_none): Likewise. (rust_flatten_rebind): Likewise. (rust_flatten_rebind_nested): Likewise. (rust_flatten_list): Likewise. * resolve/rust-ast-resolve-item.h (class Import): New. gcc/testsuite/ChangeLog: * rust/compile/use_2.rs: New test. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
force-pushed
the
fix-import-as
branch
from
e7c6e69 to
475715c
Compare
|
Did a quick rebase, this should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rebinding imports, and should also get us closer to working glob imports.