Borrowck: variance analysis #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdupak
force-pushed
the
borrowck-variance-analysis
branch
2 times, most recently
from
226acd7 to
a52ab05
Compare
philberty
force-pushed
the
borrowck-variance-analysis
branch
from
a52ab05 to
a43edad
Compare
philberty
approved these changes
Feb 3, 2024
jdupak
force-pushed
the
borrowck-variance-analysis
branch
from
a43edad to
6a9bbe2
Compare
Merged
jdupak
force-pushed
the
borrowck-variance-analysis
branch
from
6a9bbe2 to
a77491d
Compare
CohenArthur
reviewed
Mar 1, 2024
jdupak
force-pushed
the
borrowck-variance-analysis
branch
from
a77491d to
3e09ddb
Compare
|
@CohenArthur I have split the context for one type processing from the global context to make it reentrant and integrated the global one in the typecheck context. |
CohenArthur
reviewed
Mar 19, 2024
gcc/rust/ChangeLog: * typecheck/rust-tyty-subst.cc (SubstitutionRef::get_arg_at): Add unified API. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
gcc/rust/ChangeLog: * Make-lang.in: Add new .cc file. * rust-session-manager.cc (Session::compile_crate): Run analysis. * typecheck/rust-tyty-variance-analysis-private.h: New file. * typecheck/rust-tyty-variance-analysis.cc: New file. * typecheck/rust-tyty-variance-analysis.h: New file. * typecheck/rust-typecheck-context.cc (TypeCheckContext::get_variance_analysis_ctx): Variance analysis context. * typecheck/rust-hir-type-check.h (TypeCheckItem::visit): Variance analysis context. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): Collect variance info from types. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
jdupak
force-pushed
the
borrowck-variance-analysis
branch
from
3e09ddb to
dc90ea9
Compare
CohenArthur
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2814 (merged)