CI: bump clippy to v1.84; enable --all-features (#94)

Includes clippy fixes for code which previously wasn't checked because it was feature-gated
RustCrypto · Jan 21, 2025 · d60e0d0 · d60e0d0
1 parent 2425fe5
commit d60e0d0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/workspace.yml b/.github/workflows/workspace.yml
@@ -21,10 +21,10 @@ jobs:
     timeout-minutes: 45
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@1.81
+      - uses: dtolnay/rust-toolchain@1.84
         with:
           components: clippy
-      - run: cargo clippy -- -D warnings
+      - run: cargo clippy --all-features -- -D warnings
       # TODO: - run: cargo clippy --all-features --all-targets -- -D warnings
 
   doc:

diff --git a/ml-kem/src/algebra.rs b/ml-kem/src/algebra.rs
@@ -187,8 +187,8 @@ pub struct NttPolynomial(pub Array<FieldElement, U256>);
 #[cfg(feature = "zeroize")]
 impl Zeroize for NttPolynomial {
     fn zeroize(&mut self) {
-        for fe in self.0.iter_mut() {
-            fe.zeroize()
+        for fe in &mut self.0 {
+            fe.zeroize();
         }
     }
 }
@@ -435,7 +435,7 @@ where
     K: ArraySize,
 {
     fn zeroize(&mut self) {
-        for poly in self.0.iter_mut() {
+        for poly in &mut self.0 {
             poly.zeroize();
         }
     }

diff --git a/x-wing/src/lib.rs b/x-wing/src/lib.rs
@@ -313,7 +313,7 @@ mod tests {
         }
 
         fn fill_bytes(&mut self, dest: &mut [u8]) {
-            self.try_fill_bytes(dest).unwrap()
+            self.try_fill_bytes(dest).unwrap();
         }
 
         fn try_fill_bytes(&mut self, dest: &mut [u8]) -> Result<(), rand_core::Error> {