Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hair "Shaved Female" #1036

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Hair "Shaved Female" #1036

merged 1 commit into from
Feb 9, 2025

Conversation

Gooslik
Copy link
Contributor

@Gooslik Gooslik commented Feb 8, 2025

Описание PR

Причёска "Женская с выбритым боком"

Медиа

Снимок экрана 2025-02-08 222915
Снимок экрана 2025-02-08 222937
Снимок экрана 2025-02-08 222949
Снимок экрана 2025-02-08 223001
Снимок экрана 2025-02-08 223011

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения
add: Добавлена причёска "HumanHairShavedFemale"

Summary by CodeRabbit

  • Новые функции
    • Добавлена новая опция для кастомизации волос: женская прическа с выбритым боком, доступная в интерфейсе на русском языке.
    • Расширена система стилей волос с добавлением нового варианта прически, поддерживающего анимацию в четырёх направлениях.

@Gooslik Gooslik requested a review from Rxup as a code owner February 8, 2025 21:00
Copy link
Contributor

coderabbitai bot commented Feb 8, 2025

Обзор

В данном изменении добавлена новая опция для настройки прически. Обновлён локализованный файл, в который добавлена строка с пометкой «marking-HumanHairShavedFemale = Женская с выбритым боком». Дополнительно, прототип кастомизации мобов получил новый marking с соответствующим идентификатором, а метаданные текстур обновлены добавлением нового состояния «shaved_female» с четырьмя направлениями. Существующая функциональность не была изменена, обновление лишь расширяет набор доступных стилей.

Изменения

Файл(ы) Изменения
Resources/Locale/ru-RU/…/human-hair.ftl Добавлена новая запись: «marking-HumanHairShavedFemale = Женская с выбритым боком» для локализации.
Resources/Prototypes/…/human_hair.yml Добавлен новый marking с id «HumanHairShavedFemale», задающий тип маркировки для волос и с указанием ссылки на спрайт.
Resources/Textures/…/human_hair.rsi/meta.json В массив «states» добавлено состояние «shaved_female» с параметром "directions": 4 для текстур кастомизации.

Схема последовательности

sequenceDiagram
    participant U as Пользователь
    participant CS as Система кастомизации
    participant L as Локализация
    participant P as Прототипы
    participant T as Текстуры

    U->>CS: Запрос вариантов стиля волос
    CS->>L: Получить локализованный текст маркировки
    L-->>CS: Вернуть текст "Женская с выбритым боком"
    CS->>P: Запросить данные маркировки "HumanHairShavedFemale"
    P-->>CS: Вернуть информацию по маркировке
    CS->>T: Запросить метаданные для состояния "shaved_female"
    T-->>CS: Вернуть данные текстуры
    CS-->>U: Отобразить обновлённый стиль волос
Loading

Поэма

Я заяц-прыгун, весел и озорной,
Новый стиль волос — как вспышка, весной.
«С выбритым боком» – яркая новинка,
В строках и данных звучит мелодия.
Пусть перемены бегут, как легкий порыв,
Морковкой рад, я в танце, в новом ритме!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a59ffe and a440135.

⛔ Files ignored due to path filters (1)
  • Resources/Textures/Mobs/Customization/human_hair.rsi/shaved_female.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • Resources/Locale/ru-RU/accessories/human-hair.ftl (1 hunks)
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/human_hair.yml (1 hunks)
  • Resources/Textures/Mobs/Customization/human_hair.rsi/meta.json (1 hunks)
🔇 Additional comments (3)
Resources/Locale/ru-RU/accessories/human-hair.ftl (1)

199-199: Перевод соответствует стилю!

Перевод "Женская с выбритым боком" корректен и соответствует общему стилю локализации.

Resources/Textures/Mobs/Customization/human_hair.rsi/meta.json (1)

805-809: Состояние прически добавлено корректно!

Новое состояние "shaved_female" следует общему шаблону с 4 направлениями, как и другие прически.

Resources/Prototypes/Entities/Mobs/Customization/Markings/human_hair.yml (1)

1387-1393: Разметка прически определена правильно!

Определение разметки "HumanHairShavedFemale" соответствует стандартной структуре и корректно ссылается на спрайт.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/S Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# Нету кода. Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation S: Untriaged and removed size/S labels Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

RSI Diff Bot; head commit a440135 merging into 4a59ffe
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/human_hair.rsi

State Old New Status
shaved_female Added

@trest100
Copy link
Contributor

trest100 commented Feb 8, 2025

Kys

@nomad0260
Copy link
Collaborator

А мне нравится

@Roudenn Roudenn merged commit 89bcf75 into Rxup:master Feb 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# Нету кода. S: Untriaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants