Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict type checking #36

Merged
merged 42 commits into from
Dec 30, 2023
Merged

Add strict type checking #36

merged 42 commits into from
Dec 30, 2023

Conversation

RyanLua
Copy link
Owner

@RyanLua RyanLua commented Dec 28, 2023

Description

Fixes all warnings in Roblox Studio and improves the type annotations for type checking.

Related Issues

Closes #18

Changes Made

  • Change type annotations to not raise warning
  • Refactor functions
  • Add type annotations
  • Add comments

Checklist

  • I have tested these changes thoroughly.
  • I have reviewed my code for any potential errors or issues.
  • I have followed the code style guidelines for this project.

Additional Notes

Potential bugs to be foreseen with such large refactoring.

Code of Conduct

By submitting this issue, I agree to follow the Code of Conduct.

@RyanLua RyanLua changed the title Type checking Add strict type checking Dec 28, 2023
@RyanLua RyanLua self-assigned this Dec 28, 2023
@RyanLua RyanLua added the enhancement New feature or request label Dec 28, 2023
@RyanLua RyanLua marked this pull request as ready for review December 30, 2023 03:31
@RyanLua RyanLua added this to the v1.3.0 milestone Dec 30, 2023
@RyanLua RyanLua merged commit 173d1ab into main Dec 30, 2023
2 checks passed
@RyanLua RyanLua deleted the type-checking branch December 30, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warnings in Roblox's IDE
1 participant