Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix Node.js SDK extension setup #28

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

RyansOpenSauceRice
Copy link
Owner

This PR fixes the Node.js SDK extension setup in the build system:

  1. Adds explicit installation of Node.js SDK extension in GitHub Actions:

    - name: Install Node.js SDK extension
      run: |
        flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo
        flatpak install -y flathub org.freedesktop.Sdk.Extension.node20//24.08
  2. Improves Flatpak manifest:

    • Adds proper build environment variables
    • Sets up npm paths correctly
    • Uses offline npm cache
    • Exports necessary environment variables

These changes should fix the build error by ensuring that:

  1. The Node.js SDK extension is installed before building
  2. The build environment is properly configured
  3. npm has the correct permissions and paths

@RyansOpenSauceRice RyansOpenSauceRice marked this pull request as ready for review January 20, 2025 07:37
@RyansOpenSauceRice RyansOpenSauceRice merged commit c1c3014 into main Jan 20, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants