Skip to content

Commit

Permalink
reaction to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@i506210
i506210 authored Feb 4, 2025
1 parent a1ec907 commit 6ed5d4c
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 102 deletions.
Binary file modified file-formats/edot/.DS_Store
View file
Binary file not shown.
78 changes: 28 additions & 50 deletions file-formats/edot/edot-v1.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json",
"title": "eDocument Type",
"description": "eDocument Type",
"description": "eDocument type",
"type": "object",
"properties": {
"formatVersion": {
Expand All @@ -18,10 +18,8 @@
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 60
"maxLength": 30
},
"originalLanguage": {
"title": "Original Language",
Expand All @@ -35,17 +33,14 @@
"type": "string",
"enum": [
"standard",
"keyUser",
"cloudDevelopment"
],
"enumTitles": [
"Standard",
"ABAP for Key Users",
"ABAP Cloud Development"
],
"enumDescriptions": [
"Standard",
"ABAP for key user extensibility",
"ABAP cloud development"
],
"default": "standard"
Expand All @@ -58,42 +53,30 @@
]
},
"generalInformation": {
"title": "eDocument Type",
"description": "eDocument Type",
"title": "General Information",
"description": "General information",
"type": "object",
"properties": {
"edocumentType": {
"title": "eDocument Type",
"description": "eDoc Type",
"type": "string",
"maxLength": 10
},
"edocTypeDesc": {
"title": "Description",
"description": "eDocument Type Description",
"tableName": {
"title": "eDocument Table Name",

Check failure on line 61 in file-formats/edot/edot-v1.json

View workflow job for this annotation

GitHub Actions / Compare generated against provided 

          "title": "eDocument Local Table Name",
"description": "eDocument table name",

Check failure on line 62 in file-formats/edot/edot-v1.json

View workflow job for this annotation

GitHub Actions / Compare generated against provided 

          "description": "eDocument local table name",
"type": "string",
"maxLength": 30
},
"contingency": {
"title": "Created in Contingency Mode",
"description": "Contingency",
"description": "Created in contingency mode",
"type": "boolean"
},
"contingencyType": {
"title": "eDocument Type Created Using Contingency",
"description": "Contingency Type",
"description": "eDocument type created using contingency",
"type": "string",
"maxLength": 10
},
"tableName": {
"title": "Table Name",
"description": "Table name",
"type": "string",
"maxLength": 30
},
"archivePrepReqType": {
"archivePrepReq": {
"title": "Preprocess Before Archiving",
"description": "Archive Prep Req Type",
"description": "Preprocess before archiving",
"type": "boolean"
},
"edocumentSralConfiguration": {
Expand All @@ -103,53 +86,53 @@
"uniqueItems": true,
"items": {
"title": "SRAL Configuration Type",
"description": "eDocument SRAL Configuration type",
"description": "SRAL configuration type",
"type": "object",
"properties": {
"fileType": {
"title": "File Type",
"description": "File Type",
"description": "File type",
"type": "string",
"maxLength": 10
},
"fileStructureType": {
"fileStructure": {
"title": "File Structure Type",
"description": "File Structure type",
"description": "File structure type",
"type": "string",
"maxLength": 30
},
"fileDescriptionType": {
"fileDescription": {
"title": "File Description",
"description": "File Description type",
"description": "File description",
"type": "string",
"maxLength": 60
},
"notCloudRelevantType": {
"isCloudRelevant": {
"title": "File Cloud Relevancy",
"description": "File Cloud Relevancy type",
"description": "File cloud relevancy type",
"type": "boolean"
}
},
"additionalProperties": false,
"required": [
"fileType",
"fileStructureType"
"fileStructure"
]
}
},
"edocSpecAdditionalTable": {
"title": "eDocument Type Specific Additional Tables",
"description": "eDocument Type Specific Additional Tables",
"description": "eDocument type specific additional tables",
"type": "array",
"uniqueItems": true,
"items": {
"title": "eDocument Type Specific Additional Table Type",
"description": "eDocument Type Specific Additional Table type",
"title": "eDocument Type Specific Additional Tables",
"description": "eDocument type specific additional tables",
"type": "object",
"properties": {
"sequenceNumberType": {
"title": "Sequence Number Type",
"description": "Sequence Number",
"sequenceNumber": {
"title": "Sequence Number",
"description": "Sequence number",
"type": "string",
"maxLength": 10
},
Expand All @@ -162,18 +145,13 @@
},
"additionalProperties": false,
"required": [
"sequenceNumberType",
"sequenceNumber",
"tableName"
]
}
}
},
"additionalProperties": false,
"required": [
"edocumentType",
"edocTypeDesc",
"archivePrepReqType"
]
"additionalProperties": false
}
},
"additionalProperties": false,
Expand Down
96 changes: 45 additions & 51 deletions file-formats/edot/type/zif_aff_edot_v1.intf.abap
View file
Original file line number Diff line number Diff line change
@@ -1,90 +1,84 @@
"! <p class="shorttext synchronized" lang="en">Create eDocument Types</p>
"! eDocument types that can be used in eInvoice Process
"! <p class="shorttext synchronized" lang="en">eDocument Type</p>
"! eDocument types that can be used in eInvoice process
INTERFACE zif_aff_edot_v1 PUBLIC.

"! <p class="shorttext">eDocument Type</p>
"! Specify eDocument types
TYPES ty_edoc_type TYPE c LENGTH 10.

"! <p class="shorttext">Description</p>
"! Description
TYPES ty_short_description TYPE c LENGTH 30.
TYPES:
"! <p class="shorttext">SRAL Configuration Type</p>
"! eDocument SRAL Configuration type
"! SRAL configuration type
BEGIN OF ty_sral_configuration,
"! <p class="shorttext">File Type</p>
"! File Type
"! File type
"! $required
file_type TYPE c LENGTH 10,
file_type TYPE c LENGTH 10,
"! <p class="shorttext">File Structure Type</p>
"! File Structure type
"! File structure type
"! $required
file_structure_type TYPE c LENGTH 30,
file_structure TYPE c LENGTH 30,
"! <p class="shorttext">File Description</p>
"! File Description type
file_description_type TYPE c LENGTH 60,
"! File description
file_description TYPE c LENGTH 60,
"! <p class="shorttext">File Cloud Relevancy</p>
"! File Cloud Relevancy type
not_cloud_relevant_type TYPE abap_bool,
"! File cloud relevancy type
is_cloud_relevant TYPE abap_bool,
END OF ty_sral_configuration.
"! <p class="shorttext">SRAL Configuration Types</p>
"! SRAL Configuration types
"! <p class="shorttext">SRAL Configuration</p>
"! SRAL configuration
TYPES ty_sral_configurations TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type.

TYPES:
"! <p class="shorttext">eDocument Type Specific Additional Table Type</p>
"! eDocument Type Specific Additional Table type
"! <p class="shorttext">eDocument Type Specific Additional Tables</p>
"! eDocument type specific additional tables
BEGIN OF ty_additional_table,
"! <p class="shorttext">Sequence Number Type</p>
"! Sequence Number
"! <p class="shorttext">Sequence Number</p>
"! Sequence number
"! $required
sequence_number_type TYPE c LENGTH 10,
sequence_number TYPE c LENGTH 10,
"! <p class="shorttext">Table Name</p>
"! Table name
"! $required
table_name TYPE zif_aff_types_v1=>ty_object_name_30,
table_name TYPE zif_aff_types_v1=>ty_object_name_30,
END OF ty_additional_table.
"! <p class="shorttext">eDocument Type Specific Additional Table Types</p>
"! eDocument Type Specific Additional Table types
TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number_type.
"! <p class="shorttext">eDocument Type Specific Additional Tables</p>
"! eDocument type specific additional tables
TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number.

TYPES:
"! <p class="shorttext">General Information</p>
"! eDocument Type
"! General information
BEGIN OF ty_edoc_information,
"! <p class="shorttext">eDocument Type</p>
"! eDoc Type
"! $required
edocument_type TYPE ty_edoc_type,
"! <p class="shorttext">Description</p>
"! eDocument Type Description
"! $required
edoc_type_desc TYPE ty_short_description,
"! <p class="shorttext">eDocument Local Table Name</p>
"! eDocument local table name
table_name TYPE zif_aff_types_v1=>ty_object_name_30,
"! <p class="shorttext">Created in Contingency Mode</p>
"! Contingency
"! Created in contingency mode
contingency TYPE abap_bool,
"! <p class="shorttext">eDocument Type Created Using Contingency</p>
"! Contingency Type
"! eDocument type created using contingency
contingency_type TYPE c LENGTH 10,
"! <p class="shorttext">Table Name</p>
"! Table name
table_name TYPE zif_aff_types_v1=>ty_object_name_30,
"! <p class="shorttext">Preprocess Before Archiving</p>
"! Archive Prep Req Type
"! $required
archive_prep_req_type TYPE abap_bool,
"! Preprocess before archiving
archive_prep_req TYPE abap_bool,
"! <p class="shorttext">Additional Selection Fields</p>
"! Additional selection fields of validation report
edocument_sral_configuration TYPE ty_sral_configurations,
"! <p class="shorttext">eDocument Type Specific Additional Tables</p>
"! eDocument Type Specific Additional Tables
"! eDocument type specific additional tables
edoc_spec_additional_table TYPE ty_additional_tables,
END OF ty_edoc_information.
TYPES:
"! <p class="shorttext">Header</p>
"! The header for an ABAP main object (without source code) with a description of 30 characters (no key user)
BEGIN OF ty_header_30_cloud,
"! $required
description TYPE c LENGTH 30,
"! $required
original_language TYPE zif_aff_types_v1=>ty_original_language,
abap_language_version TYPE zif_aff_types_v1=>ty_abap_language_version_cloud,
END OF ty_header_30_cloud.

TYPES:
"! <p class="shorttext">eDocument Type</p>
"! eDocument Type
"! eDocument type
BEGIN OF ty_main,
"! <p class="shorttext">Format Version</p>
"! Format version
Expand All @@ -93,9 +87,9 @@ INTERFACE zif_aff_edot_v1 PUBLIC.
"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60,
"! <p class="shorttext">eDocument Type</p>
"! eDocument Type
header TYPE ty_header_30_cloud,
"! <p class="shorttext">General Information</p>
"! General information
"! $required
general_information TYPE ty_edoc_information,

Expand Down
2 changes: 1 addition & 1 deletion file-formats/edot/type/zif_aff_edot_v1.intf.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"formatVersion": "1",
"header": {
"description": "Create eDocument Types",
"description": "eDocument Type",
"originalLanguage": "en"
}
}

0 comments on commit 6ed5d4c

Please sign in to comment.