Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDOT] Add new object EDOT #682

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions file-formats/edoi/README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by @Markus1812, all EDOI files should not be part of this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDOI files removed

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# EDOI File Format

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.edoi.json` | 1 | [`zif_aff_edoi_v1.intf.abap`](./type/zif_aff_edoi_v1.intf.abap) | [`edoi-v1.json`](./edoi-v1.json)
207 changes: 207 additions & 0 deletions file-formats/edoi/edoi-v1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,207 @@
{
"$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edoi/edoi-v1.json",
"title": "eDocument Interface",
"description": "eDocument Interface",
"type": "object",
"properties": {
"formatVersion": {
"title": "Format Version",
"description": "Format version",
"type": "string",
"const": "1"
},
"header": {
"title": "Header",
"description": "Header",
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 60
},
"originalLanguage": {
"title": "Original Language",
"description": "Original language of the ABAP object",
"type": "string",
"minLength": 2
},
"abapLanguageVersion": {
"title": "ABAP Language Version",
"description": "ABAP language version",
"type": "string",
"enum": [
"standard",
"keyUser",
"cloudDevelopment"
],
"enumTitles": [
"Standard",
"ABAP for Key Users",
"ABAP Cloud Development"
],
"enumDescriptions": [
"Standard",
"ABAP for key user extensibility",
"ABAP cloud development"
],
"default": "standard"
}
},
"additionalProperties": false,
"required": [
"description",
"originalLanguage"
]
},
"generalInformation": {
"title": "eDocument Interface",
"description": "eDocument Interface",
"type": "object",
"properties": {
"edocumentInterfaceId": {
"title": "eDocument Interface",
"description": "eDocument Interface",
"type": "string",
"maxLength": 30
},
"interfaceDescription": {
"title": "eDocument Interface Description",
"description": "Interface Description.",
"type": "string",
"maxLength": 100
},
"interfaceDirection": {
"title": "eDocument Interface Direction",
"description": "Interface Direction.",
"type": "string",
"enum": [
"outbound",
"inbound"
],
"enumTitles": [
"Outbound",
"Inbound"
],
"enumDescriptions": [
"Outbound",
"Inbound"
],
"default": "outbound"
},
"edocumentInterfaceVersion": {
"title": "Interface Version",
"description": "Interface Version",
"type": "array",
"uniqueItems": true,
"items": {
"title": "Interface Version",
"description": "eDocument Interface Version",
"type": "object",
"properties": {
"intVersion": {
"title": "Interface Version",
"description": "Interface Version",
"type": "string",
"maxLength": 4
},
"intVersionDesc": {
"title": "Interface Version Description",
"description": "Interface Version Description",
"type": "string",
"maxLength": 30
},
"activeFrom": {
"title": "Active From",
"description": "Active from",
"type": "string",
"format": "date-time"
}
},
"additionalProperties": false,
"required": [
"intVersion",
"intVersionDesc",
"activeFrom"
]
}
},
"edocSpecAdditionalTable": {
"title": "Attribute Determination for Communication with Cloud Edition",
"description": "DRC Integration Attribute Determination",
"type": "array",
"uniqueItems": true,
"items": {
"title": "Attribute Determination for Communication with Cloud Edition",
"description": "DRC Integration Attribute Determination",
"type": "object",
"properties": {
"processType": {
"title": "Process Type",
"description": "DRC Process Type",
"type": "string",
"maxLength": 50
},
"processVersion": {
"title": "Process Version",
"description": "DRC Process Version",
"type": "string",
"maxLength": 20
},
"processSubtype": {
"title": "Process Subtype",
"description": "DRC Process Subtype",
"type": "string",
"maxLength": 50
},
"drcAction": {
"title": "Action",
"description": "DRC Process Action",
"type": "string",
"maxLength": 30
},
"respInterfaceId": {
"title": "Response Interface",
"description": "eDoc Response Interface",
"type": "string",
"maxLength": 30
},
"respIntVersion": {
"title": "Response Interface Version",
"description": "Response Interface Version",
"type": "string",
"maxLength": 4
}
},
"additionalProperties": false,
"required": [
"processType",
"processVersion",
"processSubtype",
"drcAction",
"respInterfaceId",
"respIntVersion"
]
}
}
},
"additionalProperties": false,
"required": [
"edocumentInterfaceId",
"interfaceDescription",
"interfaceDirection",
"edocumentInterfaceVersion",
"edocSpecAdditionalTable"
]
}
},
"additionalProperties": false,
"required": [
"formatVersion",
"header",
"generalInformation"
]
}
120 changes: 120 additions & 0 deletions file-formats/edoi/type/zif_aff_edoi_v1.intf.abap
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
INTERFACE zif_aff_edoi_v1 PUBLIC.

"! <p class="shorttext">Interface direction</p>
"! Interface direction
"! $required
"! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction}
"! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound}
TYPES ty_int_direction TYPE c LENGTH 1.
TYPES:
"! <p class="shorttext">Interface Version</p>
"! eDocument Interface Version
BEGIN OF ty_edoc_interface_version,
"! <p class="shorttext">Interface Version</p>
"! Interface Version
"! $required
int_version TYPE c LENGTH 4,
"! <p class="shorttext">Interface Version Description</p>
"! Interface Version Description
"! $required
int_version_desc TYPE c LENGTH 30,
"! <p class="shorttext">Active From</p>
"! Active from
"! $required
active_from TYPE sy-datum,

END OF ty_edoc_interface_version.
"! <p class="shorttext">Interface Versions</p>
"! eDocument Interface Versions
TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version.
TYPES:
"! <p class="shorttext">Attribute Determination for Communication with Cloud Edition</p>
"! DRC Integration Attribute Determination
BEGIN OF ty_edoc_int_drc_attr,
"! <p class="shorttext">Process Type</p>
"! DRC Process Type
"! $required
process_type TYPE c LENGTH 50,
"! <p class="shorttext">Process Version</p>
"! DRC Process Version
"! $required
process_version TYPE c LENGTH 20,
"! <p class="shorttext">Process Subtype</p>
"! DRC Process Subtype
"! $required
process_subtype TYPE c LENGTH 50,
"! <p class="shorttext">Action</p>
"! DRC Process Action
"! $required
drc_action TYPE c LENGTH 30,
"! <p class="shorttext">Response Interface</p>
"! eDoc Response Interface
"! $required
resp_interface_id TYPE c LENGTH 30,
"! <p class="shorttext">Response Interface Version</p>
"! Response Interface Version
"! $required
resp_int_version TYPE c LENGTH 4,

END OF ty_edoc_int_drc_attr.
"! <p class="shorttext">Interface Versions</p>
"! eDocument Interface Versions
TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type.
TYPES:
"! <p class="shorttext">General Information</p>
"! eDocument Interface
BEGIN OF ty_edoc_interface,
"! <p class="shorttext">eDocument Interface</p>
"! eDocument Interface
"! $required
edocument_interface_id TYPE c LENGTH 30,
"! <p class="shorttext">eDocument Interface Description</p>
"! Interface Description.
"! $required
interface_description TYPE c LENGTH 100,

"! <p class="shorttext">eDocument Interface Direction</p>
"! Interface Direction.
"! $required
interface_direction TYPE ty_int_direction,

"! <p class="shorttext">Interface Version</p>
"! Interface Version
"! $required
edocument_interface_version TYPE ty_edoc_interface_versions,
"! <p class="shorttext">Attribute Determination for Communication with Cloud Edition</p>
"! DRC Integration Attribute Determination
"! $required
edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes,
END OF ty_edoc_interface.
TYPES:
"! <p class="shorttext">eDocument Interface</p>
"! eDocument Interface
BEGIN OF ty_main,
"! <p class="shorttext">Format Version</p>
"! Format version
"! $required
format_version TYPE zif_aff_types_v1=>ty_format_version,
"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60,
"! <p class="shorttext">eDocument Interface</p>
"! eDocument Interface
"! $required
general_information TYPE ty_edoc_interface,

END OF ty_main.

CONSTANTS:
"! <p class="shorttext">Interface Direction</p>
"! Interface Direction
BEGIN OF co_edoc_int_direction,
"! <p class="shorttext">Outbound</p>
"! Outbound
outbound TYPE ty_int_direction VALUE 'O',
"! <p class="shorttext">Inbound</p>
"! Inbound
inbound TYPE ty_int_direction VALUE 'I',
END OF co_edoc_int_direction.
ENDINTERFACE.
7 changes: 7 additions & 0 deletions file-formats/edoi/type/zif_aff_edoi_v1.intf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"formatVersion": "1",
"header": {
"description": "Create eDocument Types",
"originalLanguage": "en"
}
}
Binary file added file-formats/edot/.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow i coudn't see this hidden file but anyhow i replaced whole folder

Binary file not shown.
5 changes: 5 additions & 0 deletions file-formats/edot/README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example is missing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an example would also help me for the review

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I am unable to generate example, I created class and Transformation but its not clear to me in the report what object to be mentioned as input.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# EDOT File Format

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json)
Loading
Loading