Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3110 make enter submit #2479

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Jan 2, 2025

Description

Allow pressing enter to submit the sign in form.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3110

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2479 January 2, 2025 23:31 Inactive
@tallulahkay tallulahkay added the needs review Pull request needs review label Jan 2, 2025
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2479 January 2, 2025 23:31 Inactive
@tallulahkay tallulahkay requested review from a team, cliu02 and cade-exygy and removed request for a team January 2, 2025 23:37
@tallulahkay tallulahkay marked this pull request as ready for review January 2, 2025 23:38
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2479 January 3, 2025 00:17 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2479 January 3, 2025 18:19 Inactive
Copy link
Collaborator

@cliu02 cliu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great workaround until we update UIC Form!

@tallulahkay tallulahkay added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Jan 3, 2025
Comment on lines +43 to +44
const emailField = document.querySelector("#email")
const passwordField = document.querySelector("#password")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work if the component is only rendered once, since they'll be undefined the first time through (though there seem to be enough extra renders that this isn't an issue in practice).

Still seems like just using a basic <form> here is the simplest one-line fix.

Copy link
Contributor Author

@tallulahkay tallulahkay Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I need from you is to PA test. If you can't or won't, I'll either ask someone else to or close this ticket and pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants