-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DAH-3110 make enter submit #2479
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great workaround until we update UIC Form!
const emailField = document.querySelector("#email") | ||
const passwordField = document.querySelector("#password") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work if the component is only rendered once, since they'll be undefined the first time through (though there seem to be enough extra renders that this isn't an issue in practice).
Still seems like just using a basic <form>
here is the simplest one-line fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I need from you is to PA test. If you can't or won't, I'll either ask someone else to or close this ticket and pr.
Description
Allow pressing enter to submit the sign in form.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3110
Checklist before requesting review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
Code quality
Review instructions
Request review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineers