Support single-quotes for parsing connection strings #1212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am currently assuming that it is enough for the parsing to properly understand that single quotes are also quotes and that other parts of the code don't implicitly rely on the parsed connection string using a specific kind of quotes. The accessor functions for the original connection string make me a bit nervous in that regard... but I guess CI will tell us whether this change broke something or not 👀 |
vadz
approved these changes
Mar 4, 2025
| os << "Expected "; | ||
| if (quote == '\'') | ||
| { | ||
| os << "'"; |
There was a problem hiding this comment.
If you want to show it differently I'd do this for symmetry:
Suggested change
| os << "'"; | |
| os << R"("'")"; |
but I think we could also just use the else version in all cases.
|
Merged as caaf562 with minor changes to make this a bit more symmetrical between single and double quotes, thanks! Will also push to 4.1 branch soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1210