Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR/#118] 상세페이지(+준비중) QA #122

Merged
merged 17 commits into from
Jan 24, 2025
Merged

[REFACTOR/#118] 상세페이지(+준비중) QA #122

merged 17 commits into from
Jan 24, 2025

Conversation

jangsjw
Copy link
Contributor

@jangsjw jangsjw commented Jan 24, 2025 •
edited
Loading

Related issue 🛠

Work Description ✏️

  1. 상세페이지
  • 상세페이지 상품 컨디션 칩 클릭시 ripple 효과 제거 3e1592e
  • 상세페이지 내 내용 부분의 배경색 5a99f49
  • 상세페이지 ~건, ~건 글자 간격 문제 5294cc2
  • 배송비 표시 부분의 thousand comma 1c94f36
  • 화면끝까지 스크롤시 화면 전체가 늘어나는 애니메이션 제거 a923470
  1. 준비중
  • 준비중 화면 배경색&BackTopBar a70a94e
  • 준비중 화면(PrepareScreen) BackNav 적용 b67fa05

Screenshot 📸

123.mp4

To Reviewers 📢

TopBar 하단 ShowBorder 적용 때문에 commonTopBar, BackTopBar 약간 수정했습니다!

jangsjw added 15 commits January 24, 2025 05:11
@jangsjw
[MOD/#118] 글자 간격 수정
5294cc2
@jangsjw
[MOD/#118] 배송비 표시 부분의 thousand comma
1c94f36
@jangsjw
[MOD/#118] 채팅하기 하단 선 제거
5407fe1
@jangsjw
[MOD/#118] 배경색 White 적용
5a99f49
@jangsjw
[MOD/#118] 상세페이지 상품 컨디션 칩 클릭시 ripple 효과 발생 제거
3e1592e
@jangsjw
[MOD/#118] DetailPage import문 제거
8b96de0
@jangsjw
[MOD/#118] 상세페이지 스크롤 영역에서 바운스 효과를 제거
a923470
@jangsjw
[MOD/#118] 준비중 배경색 white 적용
a70a94e
@jangsjw
[MOD/#118] BackTopBar showBorder&borderColor 적용
b76a425
@jangsjw
[MOD/#118] CommonTopBar showBorder&borderColor 적용
b29c382
@jangsjw
[MOD/#118] 배경색 white&BackTopBar(구분선x) 적용
889204c
@jangsjw
[MOD/#118] 배경색 white&BackTopBar(구분선x) 적용
6250bd6
@jangsjw
[MOD/#118] 준비중 화면 BackNac 적용
b67fa05
@jangsjw
[DEL/#118] import 제거
515b31c
@jangsjw
[MERGE/#118] pulled develop
98bcb09
@jangsjw jangsjw self-assigned this Jan 24, 2025
boiledEgg-s
boiledEgg-s approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완벽합니다!! QA 해결하시느라 고생많으셨어요~

jm991014
jm991014 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@jm991014 jm991014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 머지해요~

@jm991014 jm991014 merged commit 9b454a9 into develop Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm991014 jm991014 jm991014 approved these changes

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@chrin05 chrin05 Awaiting requested review from chrin05

@yeonjeen yeonjeen Awaiting requested review from yeonjeen

Assignees

@jangsjw jangsjw

Labels
모드레드재원 👿 재원 REFACTOR ♻️ 전면 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 상세페이지 QA
3 participants
@jangsjw @jm991014 @boiledEgg-s