[FIX/#55] 바텀바 스택 수정 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
requested review from
jm991014,
chrin05,
yeonjeen and
jangsjw
and removed request for
a team
chrin05
approved these changes
Jan 20, 2025
Comment on lines
60
to
62
|
|
||
| BackHandler(enabled = backPressedState) { | ||
| if (System.currentTimeMillis() - backPressedTime <= 2000) { |
Comment on lines
67
to
68
| snackBarHostState.showSnackbar( | ||
| message = "버튼을 한 번 더 누르면 종료돼요", |
There was a problem hiding this comment.
p2: 이부분도 String 추출하면 좋을 거 같아요
yeonjeen
approved these changes
Jan 20, 2025
| backPressedState = true | ||
| coroutineScope.launch { | ||
| snackBarHostState.showSnackbar( | ||
| message = "버튼을 한 번 더 누르면 종료돼요", |
There was a problem hiding this comment.
이 부분은 디자인 확정이 안되서 추후에 수정할게요!
Comment on lines
+112
to
+123
| item { | ||
| HomeUiStateGroup( | ||
| uiState = uiState.bannerImages, | ||
| success = { uiState -> | ||
| HomeBannerPager( | ||
| bannerImages = uiState.toImmutableList(), | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .aspectRatio(360f / 230f), | ||
| ) | ||
| }, | ||
| ) |
Comment on lines
+125
to
+137
| HomeUiStateGroup( | ||
| uiState = uiState.recommendedItems, | ||
| success = { uiState -> | ||
| HomeRecommendationItemGroup( | ||
| recommendedItems = uiState.toImmutableList(), | ||
| onLikeClick = onLikeClick, | ||
| onItemClick = onItemClick, | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(top = 43.dp), | ||
| ) | ||
| }, | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
20250120_.mp4
To Reviewers 📢