Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD/#71] 토큰 및 URL 추가 #72

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

boiledEgg-s
Copy link
Member

Related issue 🛠

Work Description ✏️

  • local.properties 수정
  • 빌드 파일 수정
  • BuildConfig 접근 코드 추가

To Reviewers 📢

  • 고정 토큰과 URL 추가했습니다.
  • 노션 "관계자외 출입금지" 업데이트했으니 확인해주시고 복붙하세요~

@boiledEgg-s boiledEgg-s added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 암살자석준 😡 석준 labels Jan 21, 2025
@boiledEgg-s boiledEgg-s requested a review from a team January 21, 2025 09:14
@boiledEgg-s boiledEgg-s self-assigned this Jan 21, 2025
@boiledEgg-s boiledEgg-s requested review from jm991014, chrin05, yeonjeen and jangsjw and removed request for a team January 21, 2025 09:14
Copy link
Contributor

@chrin05 chrin05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고핑

@@ -101,7 +102,7 @@ object NetworkModule {
client: OkHttpClient,
factory: Converter.Factory,
): Retrofit = Retrofit.Builder()
.baseUrl("") //TODO: 서버 IP 주입
.baseUrl(BASE_URL) //TODO: 서버 IP 주입
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: 완료한 부분은 주석을 삭제해도 좋을 거 같습니다.

Copy link
Contributor

@jm991014 jm991014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

@boiledEgg-s boiledEgg-s merged commit 461a5e6 into develop Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 암살자석준 😡 석준
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] base url 및 token 설정
4 participants