Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 상세페이지 QA 반영 #204

Merged
merged 8 commits into from
Jan 24, 2025
Merged

[FIX] 상세페이지 QA 반영 #204

merged 8 commits into from
Jan 24, 2025

Conversation

Taew00k
Copy link
Collaborator

@Taew00k Taew00k commented Jan 24, 2025

🛰️ 관련 이슈

해결한 이슈 번호를 작성해주세요
close #199

🧑‍💻 작업 내용

작업한 내용을 간략히 작성해주세요

  • 네이버 지도 렌더링 settiemout으로 0.5초 지연했습니다
  • 탭바 제대로 안 붙었던 것을 1초 지연하여 계산하는 것으로 해결했습니다
  • 사찰 이미지 empty 크기 조정했습니다
  • 상세 페이지 empty일때 margin 조정했습니다
  • 네이버 큰 지도에서 돌아올때 스크롤이 아래로 가게 했습니다

🗯️ PR 포인트

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

🚀 알게된 점

기록하며 개발하기!

📖 참고 자료 (선택)

참고했던 문서들 공유하기!

📸 스크린샷 (선택)

Copy link

github-actions bot commented Jan 24, 2025

🪷 Storybook 확인 🪷
🔗 https://677fa9af1269762b7858c29f-euxqvujjbl.chromatic.com/

Copy link
Collaborator

@maylh maylh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ...?

Copy link
Collaborator

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTimeout으로 해당 로직을 수정하셨군요 해당 로직 나중에는 async await 으로 수정하시면 더욱 좋을 것 같습니다

@@ -69,7 +69,7 @@ const TempleStayCard = ({
) : (
<div
className={
isHorizontal ? styles.horizontalEmptyImgSection : styles.verticalEmptyImgSection
isHorizontal ? styles.verticalEmptyImgSection : styles.horizontalEmptyImgSection
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명 수정 부탁드려요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!!

@Taew00k Taew00k merged commit ed433d5 into develop Jan 24, 2025
5 checks passed
@Taew00k Taew00k deleted the fix/#199/detail-qa branch January 24, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 템플스테이 상세페이지 QA 대응
3 participants