Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#146 report navigation mvi #176

Open
wants to merge 18 commits into
base: juri
Choose a base branch
from

Conversation

juri123123
Copy link
Collaborator

🔗 연결된 이슈

📄 작업 내용

  • 신고하기 MVI 적용
  • 네비게이션 MVI 적용

👀 기타 더 이야기해볼 점

  • navigationManager에서 view를 build하는 부분을 MVI 구조로 변경하지 못했습니다 ! ...
  • view를 return해야하는데 dispatch 함수를 거쳐서 view를 return하는 구조를 어떻게 해야할지 모르겠어서 일단 현상 유지했습니다 ~~..
  • +++ 커밋으로 보지 말고 전체 file change로 봐주세요 !!! ㅜ

@juri123123 juri123123 added refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) chore 별로 중요한 수정이 아닐 때 사용 (짬처리용, 비생산적인 경우) Juri 나는주리 labels Jan 30, 2025
@juri123123 juri123123 self-assigned this Jan 30, 2025
@juri123123 juri123123 linked an issue Jan 30, 2025 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@ChoiAnYong ChoiAnYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

//

import Foundation
import SwiftUI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SwiftUI를 import 해야되나요?


//TODO: 여기 어떻게 할지 생각해보기.........
@ViewBuilder
func build(_ view: ViewType) -> some View {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고민을 해봐도 답이 안 나오네요...

Comment on lines +10 to +21
enum ReportIntent {
case reportReasonButtonTapped(ReportType)
case reportPostButtonTapped(Int)
case backgroundTapped

case descriptionChanged(String)
case isErrorChanged(Bool)

case backButtonTapped

case onAppear(NavigationManager)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띄어쓰기를 하신 것은 의도 인가요~?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 별로 중요한 수정이 아닐 때 사용 (짬처리용, 비생산적인 경우) Juri 나는주리 refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] 신고하기 + NaivgationManager MVI로 구조 변경
3 participants