Minor fixes #137
Merged
Minor fixes #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
approved these changes
Nov 26, 2024
Merged
pbrezina
approved these changes
Nov 27, 2024
Base and Client files had some minor issues in the comments that have been fixed in this patch. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
minor_fixes
branch
from
091a374 to
affe392
Compare
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
minor_fixes
branch
from
affe392 to
2ea30be
Compare
|
I'm not really sure what is happening here, but the CI errors are the ones fixed at #138 and I already rebased my branch on top of it 😕 |
|
Hmm. Let's merge it and we'll see. |
|
This fixes it #143 |
|
I have know idea, I was mainly looking at CI result as well in this case. You can try to checkout the code and build it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing shadow's test framework I discovered several issues that I've fixed