roles, adding default domain password policy management #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
force-pushed
the
roles-password-policy
branch
2 times, most recently
from
6ce3b2f to
a0156fe
Compare
danlavu
force-pushed
the
roles-password-policy
branch
6 times, most recently
from
e63f374 to
fe86c02
Compare
aplopez
reviewed
Dec 10, 2024
| "minclasses": (self.cli.option.VALUE, 5), | ||
| "priority": (self.cli.option.VALUE, 1), | ||
| } | ||
| self._add(attrs) |
There was a problem hiding this comment.
Why are you calling self._add() here but self._modify() in the else section?
There was a problem hiding this comment.
It's the way the command is constructed. IPARole._add is ipa pwpolicy add , while IPARole._modify is ipa pwpolicy modify. If enabled, we are adding the values that don't exist, to disable it, we are modifying the existing values.
There was a problem hiding this comment.
What happens if the test has code like this?
ipp = IPAPasswordPolicy(...)
...
ipp.complexity(true)
...
ipp.complexity(false)
...
ipp.complexity(true)
There was a problem hiding this comment.
Nice catch, I'll go ahead and add something to check to see if the attribute exists and decide which function to use.
There was a problem hiding this comment.
@aplopez , I added another conditional, if the policy is empty. I had to update IPAObject.get() to return None and raise no errors if the results are empty.
danlavu
force-pushed
the
roles-password-policy
branch
5 times, most recently
from
3eab089 to
13eef9b
Compare
|
The tests are passing locally. |
danlavu
force-pushed
the
roles-password-policy
branch
from
13eef9b to
10992d0
Compare
danlavu
commented
Dec 18, 2024
| "minclasses": (self.cli.option.VALUE, 5), | ||
| "priority": (self.cli.option.VALUE, 1), | ||
| } | ||
| self._add(attrs) |
There was a problem hiding this comment.
Nice catch, I'll go ahead and add something to check to see if the attribute exists and decide which function to use.
danlavu
force-pushed
the
roles-password-policy
branch
from
10992d0 to
28fffdf
Compare
danlavu
requested review from
aplopez and
spoore1
and removed request for
shridhargadekar and
pbrezina
spoore1
reviewed
Feb 4, 2025
| } | ||
| self._add(attrs) | ||
| else: | ||
| _attrs: CLIBuilderArgs = { |
There was a problem hiding this comment.
Is there a need for _attrs here vs attrs in the conditional section above the else?
There was a problem hiding this comment.
This was a mypy complaint.
Found 1 error in 1 file (checked 46 source files)
sssd_test_framework/roles/ipa.py:1673: error: Name "attrs" already defined on line 1664 [no-redef]
lint-upstream: exit 1 (0.82 seconds) /home/dlavu/git/sssd-test-framework> mypy --install-types --non-interactive sssd_test_framework tests pid=692404
lint-upstream: FAIL ✖ in 3.71 seconds
There was a problem hiding this comment.
Would defining attrs before the conditional as an empty dict solve this? It seems odd to have to define a new variable here.
|
FYI, with a couple of small modifications, all the tests pass locally for me: |
added 7 commits
February 26, 2025 08:44
* changed IPAObject.get() to return None if no results are found
danlavu
force-pushed
the
roles-password-policy
branch
from
28fffdf to
252b248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests PR, SSSD/sssd#7728
This PR is larger than I expected.
misc.py
authentication.py
roles/ad.py, roles/ipa.py, roles/samba.py, roles/ldap.py
roles/generic.py