Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create method to find currently connected network interface #148

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Create method to find currently connected network interface #148

merged 1 commit into from
Feb 26, 2025

Conversation

aborah-sudo
Copy link
Contributor

Create method to find currently connected network interface

@aborah-sudo aborah-sudo requested review from pbrezina and removed request for ikerexxe January 27, 2025 10:31
@aborah-sudo aborah-sudo assigned pbrezina and unassigned ikerexxe Jan 27, 2025
jakub-vavra-cz
jakub-vavra-cz requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

jakub-vavra-cz
jakub-vavra-cz requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

@aborah-sudo aborah-sudo force-pushed the interface branch 3 times, most recently from c6cfce5 to 0b92103 Compare January 29, 2025 07:43
jakub-vavra-cz
jakub-vavra-cz previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pbrezina
pbrezina requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is functional, but there is space for improvement. See comments inline.

pbrezina
pbrezina requested changes Feb 7, 2025
View reviewed changes
@aborah-sudo aborah-sudo force-pushed the interface branch 2 times, most recently from 3117d0d to a08f79a Compare February 7, 2025 13:26
@aborah-sudo aborah-sudo requested a review from pbrezina February 7, 2025 13:26
@aborah-sudo aborah-sudo force-pushed the interface branch 2 times, most recently from 41e8fc9 to 81bd9cf Compare February 7, 2025 13:56
jakub-vavra-cz
jakub-vavra-cz requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docstring

@aborah-sudo
Create method to find currently connected network interface
727d420 
Create method to find currently connected network interface
pbrezina
pbrezina approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it, but code looks good to me.

@jakub-vavra-cz jakub-vavra-cz merged commit f36ed61 into master Feb 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrezina pbrezina pbrezina approved these changes

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

Assignees

@pbrezina pbrezina

@jakub-vavra-cz jakub-vavra-cz

Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aborah-sudo @pbrezina @jakub-vavra-cz @ikerexxe