realm: add methods for realm utility #153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shridhargadekar
force-pushed
the
realmd_00
branch
2 times, most recently
from
08c9668 to
f088f76
Compare
pbrezina
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Hi, I think it looks good. See the comments inline.
Besides this, I have the same comments about restore as I have in the adcli PR: #145 (review) ... we can rely on IPAHost/ADHost backup/restore, but it needs to be documented. Since realm join generates keytab and sssd configuration, fs.backup should be called first.
sssd_test_framework/utils/realmd.py
Outdated
| """ | ||
| if args is None: | ||
| args = [] | ||
| dom = domain.upper() |
sssd_test_framework/utils/realmd.py
Outdated
Comment on lines
92
to
94
| args = [] | ||
| return self.host.conn.exec(["realm", "list", *args]) |
There was a problem hiding this comment.
Separate with blank line, same on other places.
realm utility is a tool manage enrollment in realm. This PR is adding methods provided by realm utility.
shridhargadekar
force-pushed
the
realmd_00
branch
from
f088f76 to
53d14a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realm utility is a tool manage enrollment in realm. This PR is adding methods provided by realm utility.