-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a profiling page #91
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the few comments, it looks good.
src/contrib/profiling-sssd.rst
Outdated
$ sudo apt install linux-tools-common linux-tools-generic | ||
|
||
|
||
Make sure SSSD's and its dependencies' debug information is available, either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds strange,
`Make sure SSSD and debugging are working by issuing debuginfod
. Otherwise, ensure all necessary debug packages are installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (I hope).
src/contrib/profiling-sssd.rst
Outdated
|
||
.. note:: | ||
|
||
It is possible that SELinux prevents ``perf`` from monitoring your process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this certain? That SELinux rules block perf from interacting with the SSSD domain? If it's for certain, then we should phrase it that way.
The shipped targetted SELinux policy will prevent ``perf`` from interacting with the SSSD process. You can look at the audit logs or put SELinux into permissive mode to confirm. You will need to add additional rules and can be done using ``audit2allow``.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly modified it as this text is meant for any distribution, not only RHEL or Fedora (although the given examples are for Fedora and Ubuntu). How does it look?
to the process while it is running. | ||
|
||
Once SSSD is running and ready to be profiled, identify the PID of the process | ||
you want to monitor (``sssd_ssh``, ``sssd_nss``, ``sssd_be``, etc.), start the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to provide more examples, as in what data will be profiled selected the common processes. We will make the assumption that administrators may fully understand the SSSD architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one more example.
Fixed the comments and also some small errors I found. |
Adding a page describing how to profile any of the SSSD daemons.
The page be seen here: https://sssdio--91.org.readthedocs.build/contrib/profiling-sssd.html