Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize sssctl tests 1. #7801

Closed
wants to merge 1 commit into from
Closed

Parametrize sssctl tests 1. #7801

wants to merge 1 commit into from

Conversation

dkarpele
Copy link
Contributor

@dkarpele dkarpele commented Jan 18, 2025 •
edited
Loading

  • Combine various sssctl tests to the single parametrized tests.

test_sssctl__check_invalid_option_name_in_snippet merges tests:

test_sssctl__check_invalid_option_name
test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet

@dkarpele dkarpele mentioned this pull request Jan 18, 2025
Closed
@alexey-tikhonov alexey-tikhonov self-assigned this Jan 20, 2025
danlavu
danlavu requested changes Jan 20, 2025
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpick, LG2M

@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from e952fa8 to 98a6736 Compare January 20, 2025 17:27
@dkarpele dkarpele requested a review from danlavu January 20, 2025 17:31
@danlavu
Copy link

danlavu commented Jan 20, 2025

Can you squash the commits?

@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from 98a6736 to 2d55c41 Compare January 20, 2025 19:25
@dkarpele
Copy link
Contributor Author

yep

@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch 2 times, most recently from 94779df to f3125dc Compare January 28, 2025 17:50
@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from f3125dc to 18ad4d7 Compare January 31, 2025 15:33
@dkarpele
Parametrize sssctl tests 1.
bf3b18b 
- Combine various sssctl tests to the single parametrized tests.

test_sssctl__check_invalid_option_name_in_snippet merges tests:
test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet

Signed-off-by: Denis Karpelevich <dkarpele@redhat.com>
@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from 18ad4d7 to bf3b18b Compare February 9, 2025 16:40
@alexey-tikhonov
Copy link
Member

@jakub-vavra-cz, would you like to take a look at the latest version?

@dkarpele
Copy link
Contributor Author

I'm closing this PR. The tests in this patch were already covered in #7802.
("[domain/local]\ninvalid_option = True", "Attribute 'invalid_option' is not allowed") is covered by https://github.com/sssd/sssd/blob/master/src/tests/system/tests/test_sssctl.py#L129

("[invalid/local]\ninvalid_option = True", "Section [invalid/local] is not allowed") is covered by https://github.com/sssd/sssd/blob/master/src/tests/system/tests/test_sssctl.py#L130

@dkarpele dkarpele closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlavu danlavu danlavu approved these changes

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz left review comments

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

Assignees

@danlavu danlavu

@alexey-tikhonov alexey-tikhonov

Labels
Accepted Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkarpele @danlavu @alexey-tikhonov @jakub-vavra-cz