sss-idmap: add support for more general POSIX id-mapping #7858
+732
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new calls to libsss_idmap which should allow POSIX id-mapping for more general sources like IdPs as well and not only Active Directory based sources.
If for id-mapping from a general source a string is used as input for the murmurhash based offset calculation it might be important that different UTF8 representations of the same string will lead to the same ID (normalize) or that the case of the string doe not matter for the ID calculation (casefold). By default normalization is enabled while casefolding is not.
| @@ -1376,7 +1376,7 @@ libsss_idmap_la_LIBADD = \ | |||
| $(NULL) | |||
| libsss_idmap_la_LDFLAGS = \ | |||
| -Wl,--version-script,$(srcdir)/src/lib/idmap/sss_idmap.exports \ | |||
| -version-info 5:1:5 | |||
| -version-info 6:0:6 | |||
There was a problem hiding this comment.
How does this versioning work - why not 6:0:0?
There was a problem hiding this comment.
How does this versioning work - why not 6:0:0?
Hi,
it's libtool magic, see https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html for details. Since I didn't remove anything I followed until step 5.
HTH
bye,
Sumit
alexey-tikhonov
added
no-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new calls to libsss_idmap which should allow POSIX id-mapping for more
general sources like IdPs as well and not only Active Directory based
sources.