Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/nested sweeping/statistics #600

Merged
merged 13 commits into from
Dec 20, 2023

Conversation

SSoelvsten
Copy link
Owner

Closes #459 .

@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 statistics In the name of science! labels Dec 20, 2023
@SSoelvsten SSoelvsten self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (eccfe96) 96.972% compared to head (95a1055) 97.033%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/adiar/statistics.cpp 97.368% 6 Missing ⚠️
src/adiar/internal/algorithms/nested_sweeping.h 91.489% 4 Missing ⚠️
src/adiar/internal/algorithms/quantify.h 93.333% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #600       +/-   ##
=============================================
+ Coverage   96.972%   97.033%   +0.061%     
=============================================
  Files           84        84               
  Lines         5879      6168      +289     
=============================================
+ Hits          5701      5985      +284     
- Misses         178       183        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🟢 Regression Test (QBF 'breakthrough/3x5_11_bwnib')

'origin/internal/nested_sweeping/statistics' is a change in performance of 1.36% (stdev: 1.44%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 12991.80 12814.60
Standard Deviation 187.56 44.39

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'origin/internal/nested_sweeping/statistics' is a change in performance of 1.27% (stdev: 0.75%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 46640.40 46046.60
Standard Deviation 348.21 165.34

Number of samples: 5

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'origin/internal/nested_sweeping/statistics' is a change in performance of -0.18% (stdev: 0.51%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 112548.25 112745.75
Standard Deviation 569.28 340.02

Number of samples: 4

Copy link

🟢 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'origin/internal/nested_sweeping/statistics' is a change in performance of 2.19% (stdev: 3.54%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 17579.60 17194.80
Standard Deviation 622.64 273.16

Number of samples: 5

Copy link

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'origin/internal/nested_sweeping/statistics' is a change in performance of 2.36% (stdev: 3.06%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 42690.00 41684.60
Standard Deviation 1305.28 98.73

Number of samples: 5

Copy link

🟡 Regression Test (Picotrav 'adder')

'origin/internal/nested_sweeping/statistics' is a change in performance of -0.34% (stdev: 8.49%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 9661.30 9693.80
Standard Deviation 820.13 801.22

Number of samples: 10

Copy link

🟡 Regression Test (Picotrav 'arbiter')

'origin/internal/nested_sweeping/statistics' is a change in performance of -10.48% (stdev: 18.75%).

... origin/main origin/internal/nested_sweeping/statistics
Mean 62061.30 68566.90
Standard Deviation 590.17 12854.16

Number of samples: 10

@SSoelvsten
Copy link
Owner Author

The uncovered lines are as expected.

@SSoelvsten SSoelvsten merged commit a55d35a into main Dec 20, 2023
50 of 54 checks passed
@SSoelvsten SSoelvsten deleted the internal/nested_sweeping/statistics branch December 20, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New operation or other feature 📁 statistics In the name of science!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Sweeping Statistics
1 participant