Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/io/std renaming #703

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Internal/io/std renaming #703

wants to merge 9 commits into from

Conversation

SSoelvsten
Copy link
Owner

This way we have less TPIE and more STD. This will make switching to another
backend much easier
This better aligns with other 'external-only' regions that are still included
This can be used as a sanity-check if/when an alternative to TPIE is used
@SSoelvsten SSoelvsten added 🔥 bug Something isn't working ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens labels Feb 27, 2025
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Feb 27, 2025
@SSoelvsten SSoelvsten self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 96.98630% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.256%. Comparing base (1aa125e) to head (a636007).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/adiar/internal/data_structures/sorter.h 73.333% 8 Missing ⚠️
...nternal/data_structures/levelized_priority_queue.h 71.429% 2 Missing ⚠️
src/adiar/internal/io/node_ofstream.h 95.000% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #703       +/-   ##
=============================================
- Coverage   98.038%   97.256%   -0.783%     
=============================================
  Files           93        93               
  Lines         7137      7215       +78     
=============================================
+ Hits          6997      7017       +20     
- Misses         140       198       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 1.07% (stdev: 1.97%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 11893.33 11766.00
Standard Deviation 229.38 232.14

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.18% (stdev: 0.48%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 10076.67 10059.00
Standard Deviation 11.59 48.07

Number of samples: 3

This can be used as a sanity-check if/when an alternative to TPIE is used
Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.21% (stdev: 0.66%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 5178.00 5167.33
Standard Deviation 34.22 24.79

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.26% (stdev: 0.28%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 21916.67 21859.33
Standard Deviation 31.21 60.17

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.29% (stdev: 0.83%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 64480.67 64294.33
Standard Deviation 535.88 518.18

Number of samples: 3

@SSoelvsten SSoelvsten force-pushed the internal/io/std_renaming branch from 0a8bfd7 to a636007 Compare February 27, 2025 16:05
Copy link

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 1.26% (stdev: 0.99%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 9371.33 9253.00
Standard Deviation 92.65 25.12

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.63% (stdev: 0.47%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 5065.00 5033.33
Standard Deviation 10.15 23.80

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.52% (stdev: 0.36%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 15194.67 15115.33
Standard Deviation 55.01 40.86

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.34% (stdev: 0.45%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 16870.00 16812.33
Standard Deviation 30.51 74.90

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.02% (stdev: 0.98%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 29136.33 29142.00
Standard Deviation 21.78 286.13

Number of samples: 3

Copy link

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.22% (stdev: 1.28%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 12111.00 12138.00
Standard Deviation 87.16 155.25

Number of samples: 3

Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.35% (stdev: 0.27%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 124110.00 124547.33
Standard Deviation 150.69 342.21

Number of samples: 3

Copy link

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.36% (stdev: 1.36%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 275938.67 274954.67
Standard Deviation 2185.90 3726.14

Number of samples: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 bug Something isn't working ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant