-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal/io/std renaming #703
base: main
Are you sure you want to change the base?
Conversation
This way we have less TPIE and more STD. This will make switching to another backend much easier
This better aligns with other 'external-only' regions that are still included
This can be used as a sanity-check if/when an alternative to TPIE is used
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
=============================================
- Coverage 98.038% 97.256% -0.783%
=============================================
Files 93 93
Lines 7137 7215 +78
=============================================
+ Hits 6997 7017 +20
- Misses 140 198 +58 ☔ View full report in Codecov by Sentry. |
🟡 Regression Test (12-Queens)'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 1.07% (stdev: 1.97%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'adder')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.18% (stdev: 0.48%).
Number of samples: 3 |
This can be used as a sanity-check if/when an alternative to TPIE is used
🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.21% (stdev: 0.66%).
Number of samples: 3 |
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.26% (stdev: 0.28%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'arbiter')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.29% (stdev: 0.83%).
Number of samples: 3 |
0a8bfd7
to
a636007
Compare
🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 1.26% (stdev: 0.99%).
Number of samples: 3 |
🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.63% (stdev: 0.47%).
Number of samples: 3 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.52% (stdev: 0.36%).
Number of samples: 3 |
🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.34% (stdev: 0.45%).
Number of samples: 3 |
🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.02% (stdev: 0.98%).
Number of samples: 3 |
🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.22% (stdev: 1.28%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'mem_ctrl')'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.35% (stdev: 0.27%).
Number of samples: 3 |
🟡 Regression Test (14-Queens)'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.36% (stdev: 1.36%).
Number of samples: 3 |
file
,file_stream
, andfile_writer
(and levelized variants) #445 )stream
->ifstream
writer
->ofstream
random_access
->raccess
iofstream
to replace the few direct uses oftpie::file_stream
in Adiar.node_arc
I/O classes tonarc
to visually align withnode
.adiar::sorter
adiar::priority_queue
adiar::stack
adiar::array
adiar::vector
size_t
instead oftpie::memory_type
to remove more direct use of TPIE.