-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS 5095 login UI 2 #1401
SHS 5095 login UI 2 #1401
Conversation
Code looks good, but need to wait for the other PR to be deployed before merging this. We'll probably include it in the next release. |
@cienvaras checking on this one as well, is there work here that still needs to be deployed or can this be closed? |
@cienvaras Do we still need this or can this be removed? |
Deprecation is welcome -- if a module has been disabled then it'd be great to get it removed from the codebase. Also, in regards to uninstalling modules (such as the linked PR), there should also be an update hook to uninstall it in addition to the change in |
Closing this PR, will create new PR's for uninstalling the module with an update hook and removing from |
READY FOR REVIEW
Summary
Separate PR from #1399 just to remove the Admin Login Path module after it has been disabled. To be deployed after that one.
Urgency
medium
Steps to Test
Ensure that the module is no longer available in the Drupal module UI.
PR Checklist