Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS 5095 login UI 2 #1401

Closed
wants to merge 1 commit into from
Closed

SHS 5095 login UI 2 #1401

wants to merge 1 commit into from

Conversation

mndonx
Copy link
Contributor

@mndonx mndonx commented Nov 20, 2023

READY FOR REVIEW

Summary

Separate PR from #1399 just to remove the Admin Login Path module after it has been disabled. To be deployed after that one.

Urgency

medium

Steps to Test

Ensure that the module is no longer available in the Drupal module UI.

PR Checklist

@mndonx mndonx requested a review from cienvaras November 20, 2023 16:42
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-39 November 20, 2023 22:43
@cienvaras
Copy link
Collaborator

Code looks good, but need to wait for the other PR to be deployed before merging this. We'll probably include it in the next release.

Base automatically changed from fk-stnfd-sprint-39 to 10.0.5-release November 27, 2023 23:46
Base automatically changed from 10.0.5-release to develop December 14, 2023 18:47
@ahughes3
Copy link
Collaborator

@cienvaras checking on this one as well, is there work here that still needs to be deployed or can this be closed?

@ahughes3 ahughes3 temporarily deployed to Tugboat September 6, 2024 21:02 Destroyed
@ahughes3
Copy link
Collaborator

ahughes3 commented Sep 9, 2024

@cienvaras Do we still need this or can this be removed?

@cienvaras
Copy link
Collaborator

@ahughes3 This one was created as a follow-up to remove a module that's not used on the site anymore. @joegl is this something you'd like us to do after we stop using modules or do you prefer to keep the modules available in the codebase?

@joegl
Copy link
Contributor

joegl commented Sep 10, 2024

@ahughes3 This one was created as a follow-up to remove a module that's not used on the site anymore. @joegl is this something you'd like us to do after we stop using modules or do you prefer to keep the modules available in the codebase?

Deprecation is welcome -- if a module has been disabled then it'd be great to get it removed from the codebase.

Also, in regards to uninstalling modules (such as the linked PR), there should also be an update hook to uninstall it in addition to the change in core.extension.yml. It may also require manually deleting configuration settings.

@ahughes3 ahughes3 temporarily deployed to Tugboat September 26, 2024 19:07 Destroyed
@cienvaras
Copy link
Collaborator

Closing this PR, will create new PR's for uninstalling the module with an update hook and removing from composer.json later.

@cienvaras cienvaras closed this Oct 15, 2024
@cienvaras cienvaras deleted the SHS-5095-login-ui-2 branch October 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants