Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Link field should generate URL to file, not media entity #1427

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Regression: Link field should generate URL to file, not media entity #1427

merged 1 commit into from
Jan 10, 2024

Conversation

hectorlj
Copy link
Contributor

@hectorlj hectorlj commented Jan 3, 2024 •
edited
Loading

READY FOR REVIEW

Summary

Adds correct permissions for media_entity_download module to allow access to postcard links

Steps to Test

  1. Create a flexible page
  2. Add a postcard component
  3. In the the postcard link field, add a link to an existing media file
  4. Publish and save the new page
  5. Navigate to the new page
  6. Verify that the following roles can access the file:
  7. Anonymous
  8. Authenticated
  9. Contributor
  10. Author
  11. Site Manager

PR Checklist

@hectorlj hectorlj requested a review from cienvaras January 3, 2024 18:11
@hectorlj hectorlj self-assigned this Jan 3, 2024
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-41 January 10, 2024 20:49
cienvaras
cienvaras approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cienvaras cienvaras merged commit d9a8f4e into fk-stnfd-sprint-41 Jan 10, 2024
@cienvaras cienvaras deleted the shs-5180-link-field-file-url branch January 10, 2024 20:49
@pookmish pookmish mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@hectorlj hectorlj

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hectorlj @cienvaras