Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-4998: Add hb-raised-cards--uniform-height as checkbox on collections #1429

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

hectorlj
Copy link
Contributor

@hectorlj hectorlj commented Jan 4, 2024

READY FOR REVIEW

Summary

  1. Adds the Uniform Height boolean field to hs_collection paragraph
  2. Updates hs_collection template to set hb-raised-cards--uniform-height class based on Uniform Height field value
  3. Updates existing hs_collection paragraph content to enable Uniform Height if Raised Cards is already enabled

Steps to Test

  1. Create new Flexible Page
  2. Click on the Add Component button
  3. Add a Collection component
  4. Verify that clicking the Raised Cards checkbox causes the Uniform Height checkbox to appear, already enabled.
  5. Set the Items Per Row to 2
  6. Disable theUniform Height checkbox
  7. Using the Add Component button in the Collection component, add 2 Postcard components
  8. Add a paragraph or two to the first component and add only one line to the second component
  9. Save the new page and navigate to it
  10. Verify that the postcards are different heights, but still have the styling from the hb-raised-cards class
  11. Edit the new page
  12. Click on the Edit button on the Collection component
  13. Enable the Uniform Height checkbox
  14. Save the page and navigate to it
  15. Verify that the postcards are now the same height and still have the styling from the hb-raised-cards class
  16. Check existing content with Collection components. Content with Raised Cards enabled should have Uniform Height enabled as well. The following were used to test during development:
  • West site
    1. Understanding Attitudes in the West (Raised Cards enabled)
    2. Student Profiles (Raised Cards disabled)
  • Planning site
    1. Department External Reviews (Raised Cards disabled)
    2. Events (Raised Cards enabled)

PR Checklist

@hectorlj hectorlj requested a review from cienvaras January 4, 2024 16:47
@hectorlj hectorlj self-assigned this Jan 4, 2024
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, just found a minor issue.

@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-41 January 10, 2024 22:16
@hectorlj hectorlj requested a review from cienvaras January 10, 2024 22:35
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cienvaras cienvaras merged commit 7c91b80 into fk-stnfd-sprint-41 Jan 11, 2024
1 check passed
@cienvaras cienvaras deleted the shs-4998-add-uniform-height-checkbox branch January 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants