Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5184: Implementation: Add active trail indicator to main nav #1436

Merged
merged 1 commit into from
Jan 25, 2024
Merged

SHS-5184: Implementation: Add active trail indicator to main nav #1436

merged 1 commit into from
Jan 25, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jan 24, 2024 •
edited
Loading

READY FOR REVIEW

Summary

Add missing active trail indicator to main nav

Urgency

'low'

Steps to Test

  1. Navigate to a handful of pages to make sure the active trail is indicated as expected
  2. Test on both Colorful and Traditional themes
  3. Test with a variety of palettes
  4. Test in all resolutions

PR Checklist

@mariannuar mariannuar changed the base branch from develop to fk-stnfd-sprint-42 January 24, 2024 22:10
@mariannuar mariannuar marked this pull request as ready for review January 24, 2024 22:14
@mariannuar mariannuar requested a review from cienvaras January 24, 2024 22:18
cienvaras
cienvaras approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good, thanks!

@cienvaras cienvaras merged commit 020ef8e into fk-stnfd-sprint-42 Jan 25, 2024
5 of 8 checks passed
@cienvaras cienvaras deleted the SHS-5184-add-active-trail-indicator-to-main-nav branch January 25, 2024 16:45
@pookmish pookmish mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees
No one assigned
Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras