Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5530: hb-stretch-vertical-linked-cards utility class should also work on private pages #1478

Merged
merged 2 commits into from
Mar 15, 2024
Merged

SHS-5530: hb-stretch-vertical-linked-cards utility class should also work on private pages #1478

merged 2 commits into from
Mar 15, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Mar 14, 2024 •
edited
Loading

READY FOR REVIEW

Summary

Make hb-stretch-vertical-linked-cards utility class work on private pages

Need Review By (Date)

03/20

Urgency

medium

Steps to Test

  1. Create a private page
  2. Add a Private Collection component
  3. Add 3 Postcards with the Vertical Linked Card
  4. Remember to add the hb-stretch-vertical-linked-cards utility class
  5. Confirm all the cards have the same height
  6. Repeat the same for Public/Flexible Page to confirm everything still looks as expected there

PR Checklist

@mariannuar mariannuar requested a review from cienvaras March 14, 2024 17:42
@mariannuar mariannuar self-assigned this Mar 14, 2024
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-46 March 15, 2024 17:48
@cienvaras
Merge branch 'fk-stnfd-sprint-46' of github.com:SU-HSDO/suhumsci into…
ca5b6ff 
… shs-5530-hb-stretch-vertical-linked-cards-work-on-private-pages
cienvaras
cienvaras approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great: 🚀

@cienvaras cienvaras merged commit 951ba76 into fk-stnfd-sprint-46 Mar 15, 2024
5 of 7 checks passed
@cienvaras cienvaras deleted the shs-5530-hb-stretch-vertical-linked-cards-work-on-private-pages branch March 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@mariannuar mariannuar

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras