Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall page cache query ignore #1499

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

pookmish
Copy link
Member

READY FOR REVIEW

Summary

[briefly summarize the changes here]

Need Review By (Date)

['10/30', 'asap', etc.]

Urgency

['low', 'medium', 'high', etc.]

Steps to Test

  1. [First testing step]
  2. ...

PR Checklist

@pookmish pookmish changed the base branch from develop to 10.1.9-release April 10, 2024 15:49
@pookmish pookmish requested a review from joegl April 10, 2024 15:49
@pookmish pookmish force-pushed the uninstall-page_cache_query_ignore branch from 1e9e690 to 6ca9051 Compare April 10, 2024 15:52
/**
* Disable page_cache_query_ignore.
*/
function su_humsci_profile_update_9610() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why uninstalling with a dbupdate. Is that general best practice?

Copy link
Contributor

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pookmish pookmish merged commit 0cb45ac into 10.1.9-release Apr 10, 2024
11 of 15 checks passed
@pookmish pookmish deleted the uninstall-page_cache_query_ignore branch April 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants