SHS-5572: The arrows on a Spotlight (with no image) are displaying incorrectly on mobile #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shs-5572--fix-arrows-for-spotlights-with-no-image
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
cienvaras
added a commit
that referenced
this pull request
May 3, 2024
* SHS-5571: A11y Level A: Empty headings on Vertical Timeline components (#1502) * fix(shs-5571): A11y Level A: Empty headings on Vertical Timeline components * fix(shs-5571): minor code consistency fix in timeline template --------- Co-authored-by: Mari Núñez <mariannuar@admins-MacBook-Pro.local> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * fix(shs-5572): arrows on a Spotlight (with no image) displaying incorrectly on mobile (#1503) Co-authored-by: Mari Núñez <mariannuar@admins-MacBook-Pro.local> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * feat(shs-5574): cleanup grid styles - remove flexbox fallback * SHS-5568: Allow editors to select style on Accordion component (#1501) * feat(shs-5568): add new accordion style field * feat(shs-5568): add hb-accordion-secondary class if new field is set to * feat(shs-5568): add hb-accordion-secondary class to a parent wrapper class * feat: add hs-accordion-secondary to details element * chore: remove unused statement * feat(shs-5568): update styles for handling secondary accordion paragraph option * feat(shs-5568): add update hook to set field_accordion_style to default on existing accordion components --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * fix(shs-5091): fix empty headings on views (#1509) Co-authored-by: Mari Núñez <mariannuar@admins-MacBook-Pro.local> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-5583: empty headings in banners and spotlights (#1510) * fix(shs-5583): empty headings in banners and spotlights * fix(shs-5583): minor fix in spotlight and gradient-hero templates --------- Co-authored-by: Mari Núñez <mariannuar@admins-MacBook-Pro.local> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * fix(shs-5574): prevent grid element overflow * chore(shs-5574): update percy cli version / fix percy default test to consolidate colorful and traditional --------- Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com> Co-authored-by: Mari Núñez <mariannuar@admins-MacBook-Pro.local> Co-authored-by: Hector Lopez <hectorlopeztrejo9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Fix arrows position on mobile for Spotlight (with no image)
Need Review By (Date)
04/19
Urgency
medium
Steps to Test
PR Checklist