SHS-5631: Retire legacy codebase #1559
Conversation
…-5631-retire-legacy-codebase
|
@joegl We're planning to add this PR to this sprint's release, but I was wondering if it's possible for you to take a quick look before, to make sure we're not missing anything. Thanks! There's a follow-up PR (#1562) that we intend to include in the next release to remove the legacy theme files (and the |
There was a problem hiding this comment.
Looks fine to me. Just left one comment on the update hook. You might also want to merge the latest 11.0.1-release branch into the fk-stnfd-sprint-53 sprint branch before merging.
| $extension_config = \Drupal::service('config.factory')->get('core.extension'); | ||
| $legacy_themes = [ | ||
| 'archaeology', | ||
| 'francestanford', | ||
| 'mathematics', | ||
| 'su_humsci_subtheme', | ||
| 'su_humsci_theme', | ||
| ]; | ||
| // Filter out the themes that are not installed. | ||
| $installed_themes = array_filter($legacy_themes, function ($theme) use ($extension_config) { | ||
| return $extension_config->get("theme.{$theme}") !== NULL; | ||
| }); |
There was a problem hiding this comment.
Why not just use \Drupal::service('extension.list.theme)->getList() to get a list of installed themes?
There was a problem hiding this comment.
@joegl Thanks for the feedback! I just implemented the change, just replaced the getList() method for getAllInstalledInfo(), because getList() returns all available themes, not only the installed ones.
… shs-5631-retire-legacy-codebase
* feat(shs-5664): back to top goes all the way (#1558) * SHS-5620: CSS Code Cleanup: Hero mixins cleanup and improvements (#1557) * fix(SHS-5648): spotlight link to /media/<id> rendered as wrong URL (#1546) * fix(shs-5653): add missing vertical spacing in mobile grid (#1549) * feat(shs-5645): update multi-select box default text (#1547) * feat(shs-5646): make the multi-select box and single select box have square edges in Traditional (#1548) * SHS-5639 issues with toolbar not behaving correctly after logging out then logging back in (#1554) * fix(SHS-5639): fatal JS errors both when logged out/in. * fix(SHS-5639): toolbar does not behave correctly when logging out and then back in * feat(shs-5620): fix minor issues detected on hero mixins * feat(shs-5620): fix minor issues detected in hb-hero-full-width mixin * feat(shs-5620): fix more minor issues detected in hb-hero-link-field and hb-hero-button mixins * fix(shs-5620): fix margin top in hb-gradient-hero * fix(shs-5620): linter errors * SHS-5631: Retire legacy codebase (#1559) * feat(shs-5631): uninstall legacy themes and remove related configuration * fix(shs-5631): remove references to su_humsci_theme in hs_layouts module * chore(shs-5631): update documentation to remove references to legacy themes * fix(shs-5631): refactor legacy themes uninstall code * feat(shs-5656): upgrade decanter to current version (#1568) * SHS-5643 rethink the purpose of alt text listing (#1560) * chore(SHS-5643): enable Views options so that we can see (and debug) its queries * fix(SHS-5643): misc bugs with alt text listing * fix(SHS-5643): fixed fatal PHP errors when looking at the default view display * fix(shsh-5643): update image alt text view filter labels * feat(shs-5513): colorband link text character limit (#1569)
READY FOR REVIEW
Summary
hs_layoutsmodule to remove references tosu_humsci_theme.su_humsci_themein the documentationNeed Review By (Date)
06/28
Urgency
medium
Steps to Test
hs_traditionalandhs_colorfulsites locallyarchaeology)francestanford)mathematics)su_humsci_theme)su_humsci_subtheme)PR Checklist