Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5643 rethink the purpose of alt text listing #1560

Merged

Conversation

dalin-
Copy link
Collaborator

@dalin- dalin- commented Jun 24, 2024

READY FOR REVIEW

Summary

https://fourkitchens.clickup.com/t/36718269/SHS-5643
A few tweaks to Views config to fix misc bugs.

Need Review By (Date)

end of sprint

Urgency

normal

Steps to Test

Visit /admin/content/alt

  1. are the exposed filters clear?
  2. Does click-sorting work on all columns (note that some fields might have a leading tab that could confuse you)?
  3. Try to visit the page while logged out, do you get a 403?

PR Checklist

@dalin- dalin- requested a review from cienvaras June 24, 2024 17:36
@ahughes3
Copy link
Collaborator

@dalin- @cienvaras Can we change the exposed filter labels to be Alt Text and Search Alt Text

Screenshot 2024-06-25 at 2 40 31 PM

@dalin-
Copy link
Collaborator Author

dalin- commented Jun 25, 2024

@ahughes3
The 3rd filter hasn't been changed and still remains "Search Alt Text".

Your suggestion for the 2nd filter would make it almost the same as the original: "Alternative Text". What we did as part of this ticket was rename to "Missing Alt Text" which I thought made it more clear that you use this filter to find stuff that needs fixing.

But I'm happy to return it to "Alt Text" if you prefer.

@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-53 June 29, 2024 00:07
@cienvaras cienvaras merged commit b4702c4 into fk-stnfd-sprint-53 Jun 29, 2024
13 of 17 checks passed
@cienvaras cienvaras deleted the SHS-5643_Rethink-the-purpose-of-Alt-text-listing branch June 29, 2024 00:28
joegl pushed a commit that referenced this pull request Jul 1, 2024
* feat(shs-5664): back to top goes all the way (#1558)
* SHS-5620: CSS Code Cleanup: Hero mixins cleanup and improvements (#1557)
* fix(SHS-5648): spotlight link to /media/<id> rendered as wrong URL (#1546)
* fix(shs-5653): add missing vertical spacing in mobile grid (#1549)
* feat(shs-5645): update multi-select box default text (#1547)
* feat(shs-5646): make the multi-select box and single select box have square edges in Traditional (#1548)
* SHS-5639 issues with toolbar not behaving correctly after logging out then logging back in (#1554)
* fix(SHS-5639): fatal JS errors both when logged out/in.
* fix(SHS-5639): toolbar does not behave correctly when logging out and then back in
* feat(shs-5620): fix minor issues detected on hero mixins
* feat(shs-5620): fix minor issues detected in hb-hero-full-width mixin
* feat(shs-5620): fix more minor issues detected in hb-hero-link-field and hb-hero-button mixins
* fix(shs-5620): fix margin top in hb-gradient-hero
* fix(shs-5620): linter errors
* SHS-5631: Retire legacy codebase (#1559)
* feat(shs-5631): uninstall legacy themes and remove related configuration
* fix(shs-5631): remove references to su_humsci_theme in hs_layouts module
* chore(shs-5631): update documentation to remove references to legacy themes
* fix(shs-5631): refactor legacy themes uninstall code
* feat(shs-5656): upgrade decanter to current version (#1568)
* SHS-5643 rethink the purpose of alt text listing (#1560)
* chore(SHS-5643): enable Views options so that we can see (and debug) its queries
* fix(SHS-5643): misc bugs with alt text listing
* fix(SHS-5643): fixed fatal PHP errors when looking at the default view display
* fix(shsh-5643): update image alt text view filter labels
* feat(shs-5513): colorband link text character limit (#1569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants