Four Kitchens Release - Sprint 53 #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mari Nez <mariannuar@gmail.com>
… fk-stnfd-sprint-53
* fix(SHS-5648): spotlight link to /media/<id> rendered as wrong URL (#1546) * fix(shs-5653): add missing vertical spacing in mobile grid (#1549) * feat(shs-5645): update multi-select box default text (#1547) Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * feat(shs-5646): make the multi-select box and single select box have square edges in Traditional (#1548) Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * SHS-5639 issues with toolbar not behaving correctly after logging out then logging back in (#1554) * fix(SHS-5639): fatal JS errors both when logged out/in. * fix(SHS-5639): toolbar does not behave correctly when logging out and then back in Remove all toolbar local/session storage data on logout to eliminate conflicting values. --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> * feat(shs-5620): fix minor issues detected on hero mixins * feat(shs-5620): fix minor issues detected in hb-hero-full-width mixin * feat(shs-5620): fix more minor issues detected in hb-hero-link-field and hb-hero-button mixins * fix(shs-5620): fix margin top in hb-gradient-hero * fix(shs-5620): linter errors --------- Co-authored-by: Dave Hansen-Lange <1127349+dalin-@users.noreply.github.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: Mari Nez <mariannuar@gmail.com>
* feat(shs-5631): uninstall legacy themes and remove related configuration * fix(shs-5631): remove references to su_humsci_theme in hs_layouts module * chore(shs-5631): update documentation to remove references to legacy themes * fix(shs-5631): refactor legacy themes uninstall code
Co-authored-by: Mari Nez <mariannuar@gmail.com>
* chore(SHS-5643): enable Views options so that we can see (and debug) its queries * fix(SHS-5643): misc bugs with alt text listing * fix(SHS-5643): fixed fatal PHP errors when looking at the default view display * fix(shsh-5643): update image alt text view filter labels --------- Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
joegl
reviewed
Jul 1, 2024
Comment on lines
+196
to
+202
| $display = $view->getDisplay(); | ||
| $display_options = &$display->options; | ||
| $default_display = &$display; | ||
| if (!empty($display->default_display)) { | ||
| $default_display = &$display->default_display; | ||
| } | ||
| $default_options = &$default_display->options; |
There was a problem hiding this comment.
What are all the & references for here?
joegl
reviewed
Jul 1, 2024
There was a problem hiding this comment.
There are 6 sites still using legacy themes. 5 of them are old and have been replaced with newer sites, and are due for being cleaned up. However, the default site still uses the The default site installs with the su_humsci_theme legacy theme -- what theme should we be using for the default site? The default site is the site getting used in tests and we'll need to change this in the profile configuration.humsci_colorful theme. I'm going to change all 6 of these sites on prod/stage to use that theme so the update hook doesn't fail and no changes should be necessary .
Full list for reference:
- default: 'system.theme:default': su_humsci_theme
- We'll want to pick a theme to set the default site to.
- archaeology: 'system.theme:default': archaeology
- This site was replaced with archaeology2023 as the live site.
- mathematics: 'system.theme:default': mathematics
- This site was replaced with mathematics2024 as the live site.
- mcs: 'system.theme:default': su_humsci_theme
- This site was replaced with mcs2023 as the live site.
- philit: 'system.theme:default': su_humsci_theme
- This site was replaced with philit2023 as the live site.
- symsys: 'system.theme:default': su_humsci_theme
- This site was replaced with symsys2023 as the live site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Need Review By (Date)
07/03
Urgency
medium
Steps to Test
SHS-5664
a. Scroll down and click the
Back to topbuttonb. Confirm the page is scroll all the way to the top
SHS-5620
a. Confirm heros, banners, spotlights still look the same
SHS-5631
hs_traditionalandhs_colorfulsites locallyarchaeology)francestanford)mathematics)su_humsci_theme)su_humsci_subtheme)SHS-5656
SHS-5643
Visit
/admin/content/altSHS-5513
ColorbandcomponentBoth URL and Link text are required when adding a link. When displayed, the Link text is trimmed to 80 characters.and that as you're typing, you can see indication of how many characters you can usePR Checklist