Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5673: add color variables to wysiwyg css #1566

Merged
merged 1 commit into from
Jun 27, 2024
Merged

SHS-5673: add color variables to wysiwyg css #1566

merged 1 commit into from
Jun 27, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Add color variables to wysiwyg css

Need Review By (Date)

06/28

Urgency

high

Steps to Test

  • Create a Flexible page, add a Text Area and a Post card
  • In both cases, confirm that the links, buttons and other styled elements are have the right "Cardinal" red color, both in the text area itself and in the "Styles" dropdown (see image below for an example in colorful)
Screenshot 2024-06-27 at 8 22 51 AM

PR Checklist

@cienvaras cienvaras changed the title fix(shs-5673): add color variables to wysiwyg css SHS-5673: add color variables to wysiwyg css Jun 27, 2024
@cienvaras cienvaras requested a review from joegl June 27, 2024 15:18
@joegl joegl changed the base branch from develop to 11.1.1-release June 27, 2024 15:33
@joegl joegl merged commit 68e8125 into 11.1.1-release Jun 27, 2024
16 of 17 checks passed
@joegl joegl deleted the shs-5673--fix-wysiwyg-colors branch June 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl Awaiting requested review from joegl

Assignees

@joegl joegl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @joegl