SHS-5513: Colorband link text character limit #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shs-5513--colorband-link-text-character-limit
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
Jul 1, 2024
* feat(shs-5664): back to top goes all the way (#1558) * SHS-5620: CSS Code Cleanup: Hero mixins cleanup and improvements (#1557) * fix(SHS-5648): spotlight link to /media/<id> rendered as wrong URL (#1546) * fix(shs-5653): add missing vertical spacing in mobile grid (#1549) * feat(shs-5645): update multi-select box default text (#1547) * feat(shs-5646): make the multi-select box and single select box have square edges in Traditional (#1548) * SHS-5639 issues with toolbar not behaving correctly after logging out then logging back in (#1554) * fix(SHS-5639): fatal JS errors both when logged out/in. * fix(SHS-5639): toolbar does not behave correctly when logging out and then back in * feat(shs-5620): fix minor issues detected on hero mixins * feat(shs-5620): fix minor issues detected in hb-hero-full-width mixin * feat(shs-5620): fix more minor issues detected in hb-hero-link-field and hb-hero-button mixins * fix(shs-5620): fix margin top in hb-gradient-hero * fix(shs-5620): linter errors * SHS-5631: Retire legacy codebase (#1559) * feat(shs-5631): uninstall legacy themes and remove related configuration * fix(shs-5631): remove references to su_humsci_theme in hs_layouts module * chore(shs-5631): update documentation to remove references to legacy themes * fix(shs-5631): refactor legacy themes uninstall code * feat(shs-5656): upgrade decanter to current version (#1568) * SHS-5643 rethink the purpose of alt text listing (#1560) * chore(SHS-5643): enable Views options so that we can see (and debug) its queries * fix(SHS-5643): misc bugs with alt text listing * fix(SHS-5643): fixed fatal PHP errors when looking at the default view display * fix(shsh-5643): update image alt text view filter labels * feat(shs-5513): colorband link text character limit (#1569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
In the
Colorbandcomponent, update help text for the Link field:Both URL and Link text are required when adding a link. When displayed, the Link text is trimmed to 80 characters.And as the user typing, they see indication of how many characters they can use (with a "soft" limit)
Need Review By (Date)
07/01
Urgency
medium
Steps to Test
ColorbandcomponentBoth URL and Link text are required when adding a link. When displayed, the Link text is trimmed to 80 characters.and that as you're typing, you can see indication of how many characters you can usePR Checklist