SHS-5663: Editoria11y custom code cleanup #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cienvaras
approved these changes
Jul 8, 2024
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
Jul 15, 2024
* feat(shs-5663): make editoria11y work as expected (#1570) * feat(shs-5671): add bigger preview images in the editing experience (#1573) * Remove legacy themes modules (#1562) * feat(shs-5631): uninstall legacy themes and remove related configuration * chore(shs-5631): update documentation to remove references to legacy themes * feat: remove legacy themes files * feat: remove hs_mathematics module * SHS-5683: Blockquote implementation (#1575) * feat(shs-5683): blockquote implementation * feat(shs-5683): blockquote implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Add correct configuration to make Edioria11y work as it was before and uptade the custom code (which it's still needed it, I tried adding that styles in scss but it didn't work) to update the color of the text.
Need Review By (Date)
07/17
Urgency
medium
Steps to Test
PR Checklist