Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5677: Wrong color link for a vertical linked card in Private Collection #1571

Merged
merged 1 commit into from
Jul 8, 2024
Merged

SHS-5677: Wrong color link for a vertical linked card in Private Collection #1571

merged 1 commit into from
Jul 8, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jul 5, 2024 •
edited
Loading

READY FOR REVIEW

Summary

Fix wrong color link for a vertical linked card in Private Collection

Need Review By (Date)

07/17

Urgency

medium

Steps to Test

  1. In hs_traditional, edit the theme settings and change the color pairing to "Warbler"
  2. Edit https://hs-traditional.suhumsci.loc/components/collections-cards and change one of the links to an external link (starting with https://DOMAIN/)
  3. Visit the page and confirm that both regular and external link text is white in both default and hover states

PR Checklist

@mariannuar mariannuar requested a review from cienvaras July 5, 2024 20:47
@mariannuar mariannuar self-assigned this Jul 5, 2024
@cienvaras cienvaras changed the base branch from 11.1.2-release to fk-stnfd-sprint-54 July 8, 2024 01:14
cienvaras
cienvaras approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cienvaras cienvaras merged commit aeffd4c into fk-stnfd-sprint-54 Jul 8, 2024
13 of 16 checks passed
@cienvaras cienvaras deleted the shs-5677-wrong-color-link-for-a-vertical-linked-card-in-private-collection branch July 8, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@mariannuar mariannuar

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras