Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Four Kitchens Release - Sprint 54 #1572

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Four Kitchens Release - Sprint 54 #1572

merged 6 commits into from
Jul 15, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Jul 8, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • SHS-5663 - Editoria11y custom code cleanup
  • SHS-5677 - Wrong color link for a vertical linked card in Private Collection
  • SHS-5671 - Bigger Preview Images in the Editing experience
  • SHS-5668 - Remove Legacy theme
  • SHS-5683 - Blockquote implementation

Need Review By (Date)

07/17

Urgency

medium

Steps to Test

SHS-5663

  1. Import configuration
  2. Add a page with images without alternative text and headings inside subheadings to trigger Editoria11y
  3. Confirm Editoria11y is working as expected and it now has the correct color text

SHS-5677

  1. In hs_traditional, edit the theme settings and change the color pairing to "Warbler"
  2. Edit https://hs-traditional.suhumsci.loc/components/collections-cards and change one of the links to an external link (starting with https://DOMAIN/)
  3. Visit the page and confirm that both regular and external link text is white in both default and hover states

SHS-5671

  1. On Colorful and Traditional
  2. Go to media and add / edit an Image
  3. Confirm the image preview is 2x wide than it was before (Before it was using Thumbnail (100px x 100px). Now t's currently using the Small Scaled (200px))
  4. Also, please try to test this by adding/editing an image when creating a page
  5. Check the focus still works as expected

SHS-5668

  1. On Colorful and Traditional, do a manual inspection of the site. Confirm that everything works as expected.

SHS-5683

  1. On Colorful and Traditional
  2. Create a Flexible Page
  3. Add a Text Area component and add a Blockquote
  4. Check it does look according to what's in Option A in Figma
  5. Add a Testimonial component too to confirm it still look the same
  6. Please test in all the color variants in both themes
  7. Also check the blockquote block in footer (normal and dark) looks good
  8. Add blockquotes in the following pages to confirm they look good:
  1. Check VRT https://percy.io/da667d23/suhumsci/builds/35211009 for more testing

PR Checklist

@mariannuar
feat(shs-5663): make editoria11y work as expected (#1570)
5050b7c 
Co-authored-by: Mari Nez <mariannuar@gmail.com>
@cienvaras cienvaras self-assigned this Jul 8, 2024
@mariannuar
fix(shs-5677): wrong color link for a vertical linked card (#1571)
aeffd4c 
Co-authored-by: Mari Nez <mariannuar@gmail.com>
Base automatically changed from 11.1.2-release to develop July 10, 2024 16:23
@cienvaras cienvaras changed the base branch from develop to 11.1.3-release July 11, 2024 20:59
cienvaras and others added 4 commits July 11, 2024 14:59
@cienvaras
Merge branch '11.1.3-release' of github.com:SU-HSDO/suhumsci into fk-…
23ec753 
…stnfd-sprint-54
@mariannuar @cienvaras
feat(shs-5671): add bigger preview images in the editing experience (#…
2c23f74 
…1573)

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
@cienvaras
Remove legacy themes modules (#1562)
4f25851 
* feat(shs-5631): uninstall legacy themes and remove related configuration

* fix(shs-5631): remove references to su_humsci_theme in hs_layouts module

* chore(shs-5631): update documentation to remove references to legacy themes

* feat: remove legacy themes files

* feat: remove hs_mathematics module
@mariannuar @cienvaras
SHS-5683: Blockquote implementation (#1575)
f7263ba 
* feat(shs-5683): blockquote implementation

* feat(shs-5683): blockquote implementation

* fix(shs-5683): based on feedback from 11/07

* fix(shs-5683): adjustments to blockquote styles

* fix(shs-5683): fix lint error

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
@cienvaras cienvaras marked this pull request as ready for review July 13, 2024 00:01
@cienvaras cienvaras assigned joegl and unassigned cienvaras Jul 13, 2024
@cienvaras cienvaras requested a review from joegl July 13, 2024 00:16
@joegl joegl merged commit 4084e54 into 11.1.3-release Jul 15, 2024
22 of 24 checks passed
@joegl joegl deleted the fk-stnfd-sprint-54 branch July 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl joegl approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cienvaras @joegl @mariannuar