Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5671: Bigger Preview Images in the Editing experience #1573

Merged
merged 2 commits into from
Jul 11, 2024
Merged

SHS-5671: Bigger Preview Images in the Editing experience #1573

merged 2 commits into from
Jul 11, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jul 8, 2024 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Make bigger the preview images in the editing experience

Need Review By (Date)

07/12

Urgency

medium

Steps to Test

  1. On Colorful and Traditional
  2. Go to media and add / edit an Image
  3. Confirm the image preview is 2x wide than it was before (Before it was using Thumbnail (100px x 100px). Now t's currently using the Small Scaled (200px))
  4. Also, please try to test this by adding/editing an image when creating a page
  5. Check the focus still works as expected

PR Checklist

@mariannuar mariannuar requested a review from cienvaras July 8, 2024 17:45
@mariannuar mariannuar self-assigned this Jul 8, 2024
@cienvaras
Merge branch 'fk-stnfd-sprint-54' of github.com:SU-HSDO/suhumsci into…
eb064bd 
… shs-5671-bigger-preview-images-in-the-editing-experience
cienvaras
cienvaras approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🚀

@cienvaras cienvaras merged commit 2c23f74 into fk-stnfd-sprint-54 Jul 11, 2024
14 of 15 checks passed
@cienvaras cienvaras deleted the shs-5671-bigger-preview-images-in-the-editing-experience branch July 11, 2024 21:18
joegl pushed a commit that referenced this pull request Jul 15, 2024
@cienvaras
Four Kitchens Release - Sprint 54 (#1572)
4084e54 
* feat(shs-5663): make editoria11y work as expected (#1570)
* feat(shs-5671): add bigger preview images in the editing experience (#1573)
* Remove legacy themes modules (#1562)
* feat(shs-5631): uninstall legacy themes and remove related configuration
* chore(shs-5631): update documentation to remove references to legacy themes
* feat: remove legacy themes files
* feat: remove hs_mathematics module
* SHS-5683: Blockquote implementation (#1575)
* feat(shs-5683): blockquote implementation
* feat(shs-5683): blockquote implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@mariannuar mariannuar

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras