Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-4929: Hide caption/credits on images in default views #1578

Merged
merged 4 commits into from
Jul 24, 2024
Merged

SHS-4929: Hide caption/credits on images in default views #1578

merged 4 commits into from
Jul 24, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jul 15, 2024 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Hide caption credits on images in default views

Need Review By (Date)

26/07

Urgency

medium

Steps to Test

  1. On Colorful and Traditional
  2. Import configuration
  3. Go to the following pages on each site
    • /default-views/news
    • /default-views/publications
    • /default-views/people
  4. Check the caption/credits on images are hidden

Steps to update configuration to views on other existing sites

  1. Go to the view of the site (E.g: https://chemistry.suhumsci.loc/, https://religiousstudies.suhumsci.loc/ )
  2. In the Fields section, select the Image kind of field
  3. Change the configuration of the View mode from Caption/Credit to Responsive Lazy
  4. Save it and check caption/credits on images are hidden

PR Checklist

@mariannuar mariannuar requested a review from cienvaras July 15, 2024 20:06
@mariannuar mariannuar self-assigned this Jul 15, 2024
@cienvaras
Merge branch 'fk-stnfd-sprint-55' of github.com:SU-HSDO/suhumsci into…
1cd5934 
… shs-4929--hide-caption-credits-on-images-in-default-views
Base automatically changed from 11.1.3-release to develop July 24, 2024 20:48
cienvaras
cienvaras approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-55 July 24, 2024 23:29
@cienvaras cienvaras merged commit c3f0d10 into fk-stnfd-sprint-55 Jul 24, 2024
14 of 16 checks passed
@cienvaras cienvaras deleted the shs-4929--hide-caption-credits-on-images-in-default-views branch July 24, 2024 23:30
joegl pushed a commit that referenced this pull request Jul 29, 2024
@cienvaras
Four Kitchens Release - Sprint 55 (#1584)
0462081 
* SHS-5661: Remove legacy fields (#1577)
* feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box
* feat(SHS-5661): Remove other references to the overlay field
* feat(SHS-5661): Add update hook to remove legacy field
* fix(SHS-5661): Fix linting error
* fix(shs-5661): remove hero-text-overlay variants and update viewmode config
* SHS-4929: Hide caption/credits on images in default views (#1578)
* feat(shs-4929): add new media view mode and update news default views
* feat(shs-4929):  update people default views
* feat(shs-4929):  update publications default views
* SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579)
* feat(SHS-5675): Add default table header rows to new tables in CKEditor
* fix(SHS-5675): Fix linting error
* docs(SHS-5675): Add comments describing change and source of change.
* feat(SHS-5675): Update table heading color in CKEditor
* fix(shs-5675): change color variable for table headings
* fix(shs-5696): make normal the font style of blockquotes in wysiwyg (#1582)
* SHS-5693: Implementation: New Vertical Card option (#1581)
* feat(shs-5693): add view mode and and pattern for vertical button card
* feat(shs-5693): configure the Style field to use the new view mode with the right label.
* feat(shs-5693): add pattern into module preprocess function and update twig file
* feat(shs-5693): more implementations in vertical button card
* feat(shs-5693): implementations in vertical button card for colorful
* feat(shs-5693): update box shadow
* feat(shs-5693): update image position for colorful
* feat(shs-5953): use secondary button styles in traditional and fix space in colorful when there's no image
* fix(shs-5693): fix incorrect background color
cienvaras added a commit that referenced this pull request Aug 9, 2024
@codechefmarc @cienvaras @mariannuar
SHS-5629: Editors can more easily edit a caption (#1580)
ee7cd0b 
* feat(SHS-5629): Add patch to allow editing of media items in a modal from a node edit page

* fix(SHS-5629): Remove todo in patch file

* SHS-5661: Remove legacy fields (#1577)

* feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box

* feat(SHS-5661): Remove other references to the overlay field

* feat(SHS-5661): Add update hook to remove legacy field

* fix(SHS-5661): Fix linting error

* fix(shs-5661): remove hero-text-overlay variants and update viewmode config

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* SHS-4929: Hide caption/credits on images in default views (#1578)

* feat(shs-4929): add new media view mode and update news default views

* feat(shs-4929):  update people default views

* feat(shs-4929):  update publications default views

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* refactor(SHS-5629): Switch local patch for remote patch, add patch to fix missing save button on media modal

* SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579)

* feat(SHS-5675): Add default table header rows to new tables in CKEditor

* fix(SHS-5675): Fix linting error

* docs(SHS-5675): Add comments describing change and source of change.

* feat(SHS-5675): Update table heading color in CKEditor

* fix(shs-5675): change color variable for table headings

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* fix(shs-5629): revert composer.lock changes

* fix(SHS-5629): Possible fix for dialog box too low on screen

* fix(SHS-5629): Fix dialog too low on screen issue (clear browser cache to fix)

* fix(shs-5629): remove unnecesary change

* fix(shs-5629): update patch

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com>
Co-authored-by: Mari Nez <mariannuar@gmail.com>
joegl pushed a commit that referenced this pull request Aug 13, 2024
@cienvaras
Four Kitchens Release - Sprint 56 (#1597)
29f076f 
* SHS-5692: Implementation: New Spotlight design for Colorful and Traditional (#1589)
* SHS-5772: Regression: External Links on Postcards are wrong color (#1591)
* SHS-5629: Editors can more easily edit a caption (#1580)
* SHS-5661: Remove legacy fields (#1577)
* SHS-4929: Hide caption/credits on images in default views (#1578)
* SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579)
cienvaras added a commit that referenced this pull request Aug 22, 2024
@mariannuar @cienvaras @codechefmarc
SHS-5691: New color palette for Traditional (#1600)
fb74037 
* SHS-5692: Implementation: New Spotlight design for Colorful and Traditional (#1589)

* feat(shs-5692): add new field for variantion style and start implementing new styles

* feat(shs-5692): styles for colorful

* feat(shs-5692): finish styles for colorful

* feat(shs-5692): finish styles for colorful

* feat(shs-5692): finish styles for traditional

* feat(shs-5692): finish styles for traditional

* fix(shs-5692): fix on colorful

* fix(shs-5692): image dimensions and height when spotlits are in sliders

* fix(shs-5692): refactor spotlight style field class assignation

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* SHS-5772 - Regression: External Links on Postcards are wrong color (#1591)

* fix(shs-5772): regression in external links in postcards

* fix(shs-5772): update card title link styles

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* SHS-5629: Editors can more easily edit a caption (#1580)

* feat(SHS-5629): Add patch to allow editing of media items in a modal from a node edit page

* fix(SHS-5629): Remove todo in patch file

* SHS-5661: Remove legacy fields (#1577)

* feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box

* feat(SHS-5661): Remove other references to the overlay field

* feat(SHS-5661): Add update hook to remove legacy field

* fix(SHS-5661): Fix linting error

* fix(shs-5661): remove hero-text-overlay variants and update viewmode config

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* SHS-4929: Hide caption/credits on images in default views (#1578)

* feat(shs-4929): add new media view mode and update news default views

* feat(shs-4929):  update people default views

* feat(shs-4929):  update publications default views

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* refactor(SHS-5629): Switch local patch for remote patch, add patch to fix missing save button on media modal

* SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579)

* feat(SHS-5675): Add default table header rows to new tables in CKEditor

* fix(SHS-5675): Fix linting error

* docs(SHS-5675): Add comments describing change and source of change.

* feat(SHS-5675): Update table heading color in CKEditor

* fix(shs-5675): change color variable for table headings

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* fix(shs-5629): revert composer.lock changes

* fix(SHS-5629): Possible fix for dialog box too low on screen

* fix(SHS-5629): Fix dialog too low on screen issue (clear browser cache to fix)

* fix(shs-5629): remove unnecesary change

* fix(shs-5629): update patch

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com>
Co-authored-by: Mari Nez <mariannuar@gmail.com>

* feat(shs-5691): add new color pallete-for-traditional

* feat(shs-5691): add new color palette-for-traditional

* fix(shs-5691): update secondary and secondary active colors

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: Marc Berger <107938318+codechefmarc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@mariannuar mariannuar

Labels
Passes code review Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras