SHS-5693: Implementation: New Vertical Card option #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 19, 2024 14:22
…th the right label.
An error occurred while trying to automatically change base from
11.1.3-release
to
develop
July 24, 2024 20:48
…ace in colorful when there's no image
… shs-5693--new-vertical-card-option
cienvaras
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
@mariannuar Great work! Just fixed a minor issue with the background on collections with a background color. Other than that, it works great
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
Jul 29, 2024
* SHS-5661: Remove legacy fields (#1577) * feat(SHS-5661): Remove paragraph field Overlay Color on banner image with text box * feat(SHS-5661): Remove other references to the overlay field * feat(SHS-5661): Add update hook to remove legacy field * fix(SHS-5661): Fix linting error * fix(shs-5661): remove hero-text-overlay variants and update viewmode config * SHS-4929: Hide caption/credits on images in default views (#1578) * feat(shs-4929): add new media view mode and update news default views * feat(shs-4929): update people default views * feat(shs-4929): update publications default views * SHS-5675: Helping users avoid 'Table cell missing context (e.g. headings) A11y warning (#1579) * feat(SHS-5675): Add default table header rows to new tables in CKEditor * fix(SHS-5675): Fix linting error * docs(SHS-5675): Add comments describing change and source of change. * feat(SHS-5675): Update table heading color in CKEditor * fix(shs-5675): change color variable for table headings * fix(shs-5696): make normal the font style of blockquotes in wysiwyg (#1582) * SHS-5693: Implementation: New Vertical Card option (#1581) * feat(shs-5693): add view mode and and pattern for vertical button card * feat(shs-5693): configure the Style field to use the new view mode with the right label. * feat(shs-5693): add pattern into module preprocess function and update twig file * feat(shs-5693): more implementations in vertical button card * feat(shs-5693): implementations in vertical button card for colorful * feat(shs-5693): update box shadow * feat(shs-5693): update image position for colorful * feat(shs-5953): use secondary button styles in traditional and fix space in colorful when there's no image * fix(shs-5693): fix incorrect background color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Add new
Vertical Button Cardoption inPostcardNeed Review By (Date)
07/26
Urgency
medium
Steps to Test
Import configuration, compile the theme and clear cache for Colorful and Traditional. Tugboat URLS: https://hs-traditional-n2nypkdhaunsv8whsxsquwupgep0exsv.tugboatqa.com/test-postcards and https://hs-colorful-n2nypkdhaunsv8whsxsquwupgep0exsv.tugboatqa.com/test-postcards
On Colorful, create a
Flexible PageAdd a single
Postcardcomponent with theVertical Button CardAdd Collection Cards (for all the different variants: With
Raised Cards, withUniform Height, withoutRaised CardsandUniform Height, with different number of items per row )Add
PostCardswith theVertical Button Cardin collectionsCheck they all look similar to what's in Figma Option A
Please check the following with the different color palettes:
Now, on Traditional repeat steps 2, 3 and 4
Check they all look similar to what's in Figma Option D (the last one)
Please check the following with the different color palettes:
PR Checklist