SHS-5771: Make the Paragraph Drag and Drop option more visible to Site Editors

[codechefmarc]

READY FOR REVIEW

Summary

• Adds a patch and config to move the Paragraph drag and drop action from the paragraph three dot menu to the paragraph toolbar.
• Patch was created by @codechefmarc for the Paragraphs module (https://www.drupal.org/project/paragraphs/issues/3470569) and adds the following option to the widget settings form for paragraphs:

Need Review By (Date)

2024-09-11

Urgency

low

Steps to Test

1. Login to the site
2. Add a Flexible page
3. Verify that in the Main Region, there is a "Drag and drop" button that appears on the table header of the paragraph edit form.

4. Add a Hero Image into the Full-Width Region
5. Verify that the full-width region also gets a Drag and Drop button in the table header.

7. Add a Private page
8. Verify that the components paragraph also gets a Drag and drop button in the table header
9. Click on the Drag & drop button and verify that drag and drop still works

PR Checklist

• PR Checklist
• Humsci Basic PR Checklist

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208164376448509

[cienvaras]

@codechefmarc Works great, thanks! Just one detail: can you please remove the changes in composer.lock from the PR. It's better to leave this to SWS, they're the ones in charge of module updates.

[codechefmarc]

Ok, @cienvaras , reverted composer.lock changes.

[cienvaras]

Thanks @codechefmarc !

@ahughes3 Ready for you to review.

[ahughes3]

Works as expected and looks good, approved by H&S

[joegl]

I understand the need to timebox. Do you know where it's failing or which of the two suggestions is preventing it from working?

Not sure which part is causing the issue - testing it with that php-eval seems to work, so troubleshooting is tricky is all. I did notice that if I did a print_r($existing_config) that it didn't print anything, even though it works with that php-eval. A coworker gave me some other suggestions to try, mainly updating the specific key/value pairs directly in the config rather than using a whole config file. And apparently, in 10.3, we can use a piece of the new recipes initiative to do config_actions which are a much simpler way of overriding existing config. So, there are ways forward.

Yea, I'm just not sure if looping through the config key/values will set or unset all the values correctly, even if it gets most of it accomplished. The updateFromStorageRecord method should work.

[joegl]

@codechefmarc @ahughes3 Is #1599 going to make this PR irrelevant since paragraphs_browser is being deprecated?

[joegl]

Not sure which part is causing the issue - testing it with that php-eval seems to work, so troubleshooting is tricky is all. I did notice that if I did a print_r($existing_config) that it didn't print anything, even though it works with that php-eval. A coworker gave me some other suggestions to try, mainly updating the specific key/value pairs directly in the config rather than using a whole config file. And apparently, in 10.3, we can use a piece of the new recipes initiative to do config_actions which are a much simpler way of overriding existing config. So, there are ways forward.

I'm having the same issue. The database update doesn't work but running the update code manually with drush eval works.

[codechefmarc]

@codechefmarc @ahughes3 Is #1599 going to make this PR irrelevant since paragraphs_browser is being deprecated?

@joegl What I added was part of the paragraphs module directly, so not sure if the widget is changing. I'll take a look over on that PR to check first. If not, I'll make the one change you need here and let you know.

[codechefmarc]

@joegl - So, I checked PR-1599 and this PR to add drag and drop visibility is still needed as we're still using Paragraphs in the regular way, it's just the way to choose a new paragraph is new.

I did test out just changing the service as you had mentioned and again it works with the php-eval as mentioned on the command line, but not with the standard build process. I tested locally and via Tugboat and neither got the change, whereas if I kept $config_directory = new FileStorage(Settings::get('config_sync_directory')); in there, it works fine with both.

I'm out of hours this week, so I can continue to work on this next week if you wish. Let me know your thoughts. Thanks!

[joegl]

@joegl - So, I checked PR-1599 and this PR to add drag and drop visibility is still needed as we're still using Paragraphs in the regular way, it's just the way to choose a new paragraph is new.

I did test out just changing the service as you had mentioned and again it works with the php-eval as mentioned on the command line, but not with the standard build process. I tested locally and via Tugboat and neither got the change, whereas if I kept $config_directory = new FileStorage(Settings::get('config_sync_directory')); in there, it works fine with both.

I'm out of hours this week, so I can continue to work on this next week if you wish. Let me know your thoughts. Thanks!

Sounds good and thanks for all the back-and-forth. We'll definitely need to coordinate the merge and release of these 3 paragraph PR's probably in the next release cycle but it's all looking good so far. Enjoy your time off 👍

[joegl]

A quick update/summary: I'd like to merge #1574 and #1599 first, then get those changes merged into this PR and update this PR necessary. Because this change is much smaller than the other two, it's probably easier to merge those two larger PR's first and accommodate those changes here than vice-versa. CC: @ahughes3 @codechefmarc

[joegl]

Both #1574 and #1599 have been merged now. This will need to have the latest code merged in and get the conflicts resolved, and then probably get a second look to see if it needs to be updated to work with the new paragraph changes. @cienvaras @codechefmarc

[cienvaras]

@joegl the branch is updated and ready to review. I implemented the requested changes in the new update hook (hs_paragraph_types_update_10009()), but, if this is going to be merged into 11.3.1 I think it can be removed. I had to include the new settings in the update hook I created in the Add Above PR (hs_basic_page_update_10002()), because it was overriding the config in my local, so now the change is being applied twice.

[codechefmarc]

We'll have to reconcile some other code too - I just made changes to PR-1622 that also includes a hs_paragraph_types_update_10009 so mine will probably have to go to hs_paragraph_types_update_10010 is my guess. Just wanted to make a note for all of us to be aware. I can work on that one.

[codechefmarc]

PR-1622 was updated so the update hooks are now corrected.

[joegl]

Thanks @cienvaras and @codechefmarc