Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5791: Update Stanford University brand bar link #1618

Merged

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Sep 4, 2024

READY FOR REVIEW

Summary

Update Stanford University brand bar link

Need Review By (Date)

09/04

Urgency

medium

Steps to Test

  1. Visit the Tugboat site
  2. Confirm the link of the brand bar (at the top of the page) is now https://www.stanford.edu/

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat September 4, 2024 17:02 Destroyed
@mariannuar mariannuar self-assigned this Sep 4, 2024
@mariannuar mariannuar requested a review from cienvaras September 4, 2024 17:11
@ahughes3 ahughes3 temporarily deployed to Tugboat September 4, 2024 22:58 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Works as expected, thanks! Just removed a couple of extra unnecessary spaces.

@ahughes3 Ready for you to review.

@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Sep 4, 2024
@cienvaras cienvaras requested a review from ahughes3 September 4, 2024 22:58
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from joegl September 4, 2024 23:39
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Sep 4, 2024
@joegl joegl merged commit 511df4e into 11.2.4-release Sep 5, 2024
17 checks passed
@joegl joegl deleted the shs-5791-update-stanford-university-brand-bar-link branch September 5, 2024 16:28
cienvaras added a commit that referenced this pull request Sep 10, 2024
* feat(shs-5784): add new well color for collections - FE

* feat(shs-5784): add new well color for collections - FE

* fix(shs-5784): logic

* Updated dependencies

* SHS-5791: Update Stanford University brand bar link (#1618)

* SHS-5791: Update Stanford University brand bar link.

* feat(shs-5784): improve code in module and add vireo light well color

* fix(shs-5784): add import for html

* HSD8-000: Fix localist_url fieldwidget discovery (#1621)

HSD8-000: Fix localist_url fieldwidget discovery.

---------

Co-authored-by: Mari Nez <mariannuar@gmail.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: CircleCI <sws-developers@lists.stanford.edu>
Co-authored-by: Joe Gilliland-Lloyd <6943710+joegl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants