-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5791: Update Stanford University brand bar link #1618
Merged
joegl
merged 2 commits into
11.2.4-release
from
shs-5791-update-stanford-university-brand-bar-link
Sep 5, 2024
Merged
SHS-5791: Update Stanford University brand bar link #1618
joegl
merged 2 commits into
11.2.4-release
from
shs-5791-update-stanford-university-brand-bar-link
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cienvaras
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Works as expected, thanks! Just removed a couple of extra unnecessary spaces.
@ahughes3 Ready for you to review.
ahughes3
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
joegl
approved these changes
Sep 5, 2024
cienvaras
added a commit
that referenced
this pull request
Sep 10, 2024
* feat(shs-5784): add new well color for collections - FE * feat(shs-5784): add new well color for collections - FE * fix(shs-5784): logic * Updated dependencies * SHS-5791: Update Stanford University brand bar link (#1618) * SHS-5791: Update Stanford University brand bar link. * feat(shs-5784): improve code in module and add vireo light well color * fix(shs-5784): add import for html * HSD8-000: Fix localist_url fieldwidget discovery (#1621) HSD8-000: Fix localist_url fieldwidget discovery. --------- Co-authored-by: Mari Nez <mariannuar@gmail.com> Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com> Co-authored-by: CircleCI <sws-developers@lists.stanford.edu> Co-authored-by: Joe Gilliland-Lloyd <6943710+joegl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Update Stanford University brand bar link
Need Review By (Date)
09/04
Urgency
medium
Steps to Test
PR Checklist