SHS-5845: Collection with Well color for a page with a side bar menu

[cienvaras]

READY FOR REVIEW

Summary

• Fix double spacing in full width wells in pages with sidebar

Need Review By (Date)

10/09

Urgency

medium

Steps to Test

Collections

1. In both colorful and traditional reference sites, log in and visit an existing flexible page with a visible sidebar. In that page, create 2 collections with a background color. In one of them select "Limited width" as the value for "Background Color Width", and in the other one select "Full width".
2. Visit the page and confirm that the horizontal spacing between the well border are the content is the same (32px in traditional and 48px in colorful) for both the "Limited Width" and the "Full Width" versions.
3. Alternatively, you visit a page with existing collections and change the value of "Background Color Width". Here are some pages that you can use:
   • Colorful
     • Collection with Mixed Components in a Well
     • Collections Cards in a Well
   • Traditional
     • Collection with Mixed Components in a Well
     • Collections Cards in a Well

Private collections

1. In the case of the private collections, the test sites already include private pages with "Limited width" and "Full width" example private collections. In both colorful and traditional reference sites, log in and visit the following pages:
   • Colorful
     • Private Page Collection Cards Raised Uniform Stretch Limited Width
     • Private Page Collection Cards Raised Uniform Stretch Full Width
   • Traditional
     • Private Page Collection Cards Raised Uniform Stretch Limited Width
     • Private Page Collection Cards Raised Uniform Stretch Full Width
2. In each site, confirm that the horizontal spacing between the well border are the content is the same (32px in traditional and 48px in colorful) for both the "Limited Width" and the "Full Width" versions.

PR Checklist

• PR Checklist
• Humsci Basic PR Checklist

[mariannuar]

@cienvaras Looks good!

[cienvaras]

@ahughes3 Ready for you!

[ahughes3]

@cienvaras

1. Was the update applied to private collections and (regular) collections? If so can you update testing instructions for those cases as well?

2. As part of the task in ClickUp we also want to add help text to the field in private collections; I'm making a note in CLickUp but it should match the text that's on the field in the regular collection

Applies when the page is full width. If the page includes a sidebar, this option will have no effect.

[cienvaras]

@ahughes3

Was the update applied to private collections and (regular) collections? If so can you update testing instructions for those cases as well?

Yes, the styles are shared by both components. I updated the testing instructions

As part of the task in ClickUp we also want to add help text to the field in private collections; I'm making a note in CLickUp but it should match the text that's on the field in the regular collection

Done. I added the help text for the collections in another PR, but forgot the private collections. It's fixed now.

[joegl]

@cienvaras It looks like there's now a conflict based on the merged change in #1640

[cienvaras]

@joegl Conflicts fixed, ready to review again.