Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5869: Fix width in small screen sizes in Drupal user login form #1657

Merged
merged 2 commits into from
Oct 15, 2024
Merged

SHS-5869: Fix width in small screen sizes in Drupal user login form #1657

merged 2 commits into from
Oct 15, 2024

Conversation

mariannuar
Copy link
Collaborator

READY FOR REVIEW

Summary

Fix width in small screen sizes in Drupal user login form

Need Review By (Date)

10/15

Urgency

medium

Steps to Test

  1. Go to /user/login
  2. Verify the width of the input looks good in all screen sizes

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat October 15, 2024 16:05 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat October 15, 2024 16:30 Destroyed
@mariannuar mariannuar requested a review from ahughes3 October 15, 2024 16:44
@mariannuar mariannuar self-assigned this Oct 15, 2024
@mariannuar
Copy link
Collaborator Author

@ahughes3 The fix for the small screen sizes is ready for review!

@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Oct 15, 2024
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 15, 2024
@ahughes3 ahughes3 requested review from joegl and ahughes3 and removed request for ahughes3 October 15, 2024 18:02
ahughes3
ahughes3 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3
Copy link
Collaborator

@joegl this is a fix that we would like to get in this week's release for a minor front end issue we saw on stage with work from #1651

@joegl joegl merged commit f4e2ea0 into 11.3.1-release Oct 15, 2024
17 checks passed
@joegl joegl deleted the shs-5869-fix-in-drupal-user-login-form branch October 15, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahughes3 ahughes3 ahughes3 approved these changes

@joegl joegl joegl approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariannuar @ahughes3 @joegl