Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Media library images styles #1658

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Add template for image fields in su_humsci_gin_admin theme, adding the correct classes to the fields. This is needed to correctly display the images in the media library.

Need Review By (Date)

asap

Urgency

high

Steps to Test

  1. Create a Flexible Page. Add any component with an image (for example a postcard)
  2. Confirm that the images in the media library look as expected
Screenshot 2024-10-15 at 8 11 43 PM

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat October 16, 2024 02:16 Destroyed
@cienvaras cienvaras marked this pull request as ready for review October 16, 2024 02:16
@cienvaras cienvaras requested a review from joegl October 16, 2024 02:16
@cienvaras
Copy link
Collaborator Author

@joegl can you please take a look at this PR? It fixes a bug that @ahughes3 found in the media library image grid after merging the paragraph previews PR. Thanks!

@ahughes3 ahughes3 self-requested a review October 16, 2024 14:11
@joegl joegl merged commit e9cd357 into 11.3.1-release Oct 16, 2024
17 checks passed
@joegl joegl deleted the hotfix-media-library-images branch October 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants