SHS-5944: Uninstall Honeypot module #1698
Conversation
There was a problem hiding this comment.
@codechefmarc
I took a look at a tugboat site, and the module/config is all gone (as expected). I was hoping to be able to look at a log somewhere and see the Deleted @config messages, but I couldn't find that in either Tugboat or Github Actions.
Maybe I'm not the best person to review this :-)
There was a problem hiding this comment.
@codechefmarc Works as expected. There's one thing you missed though: please remove the module dependency in docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.info.yml.
|
@cienvaras - Good catch. Removed. |
There was a problem hiding this comment.
@codechefmarc LGTM, thanks for the fix!
@ahughes3 Ready for you to review.
|
@cienvaras The module is still listed at
|
|
@ahughes3 Correct. This PR only uninstalls the module, full module removal should be done in a separate PR on the next release. |
| // Remove honeypot existing config - needs to be done before uninstall. | ||
| $config_factory = \Drupal::configFactory(); | ||
|
|
||
| $config_names = [ | ||
| 'honeypot.settings', | ||
| 'ultimate_cron.job.honeypot_cron', | ||
| ]; | ||
|
|
||
| foreach ($config_names as $config) { | ||
| $config_factory->getEditable($config)->delete(); | ||
| $message = t('Deleted @config', [ | ||
| '@config' => $config, | ||
| ]); | ||
| \Drupal::logger('su_humsci_profile')->notice($message); | ||
| } | ||
|
|
There was a problem hiding this comment.
Actually, this isn't required. those configs have a dependency on the module, so disabling the module removes the configs automatically.
READY FOR REVIEW
Summary
Need Review By (Date)
2024-12-18
Urgency
low
Steps to Test
/admin/modulesPR Checklist