Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSD8-1707: Removed edit button from default people view #1701

Merged
merged 1 commit into from
Dec 19, 2024
Merged

HSD8-1707: Removed edit button from default people view #1701

merged 1 commit into from
Dec 19, 2024

Conversation

sethprime
Copy link
Contributor

READY FOR REVIEW

Summary

Removed edit button from default people view config to resolve button displaying to anonymous users.
HSD8-1707 | Edit button is viewed when logged out prior to cache clearing

Need Review By (Date)

Urgency

Low

Steps to Test

  1. Pull changes and import the updated configuration, views.view.hs_default_people.yml.
  2. Verify that the Default People view's People list link, and People list link (grouped) blocks to not have a link to edit content in their Fields section.

PR Checklist

@sethprime sethprime requested a review from pookmish December 18, 2024 22:45
@ahughes3 ahughes3 temporarily deployed to Tugboat December 18, 2024 22:45 Destroyed
pookmish
pookmish approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create the PR, make sure to use the release branch as the base to merge into.

@pookmish pookmish changed the base branch from develop to 11.6.1-release December 19, 2024 15:56
@pookmish pookmish merged commit 5031c64 into 11.6.1-release Dec 19, 2024
17 of 18 checks passed
@pookmish pookmish deleted the HSD8-1707-remove-edit-button-from-people-view branch December 19, 2024 15:57
@ahughes3
Copy link
Collaborator

@pookmish once this is rolled out will this only update the default view for sites going forward or would it update existing views? Want to prepare to see what type of work we will need to do on our end.

@pookmish
Copy link
Member

@ahughes3 , It will update only the existing "Default" view for new and existing sites. But it won't make any changes to any custom views which is probably 99% (if not 100%) displays

pookmish added a commit that referenced this pull request Jan 8, 2025
@pookmish @su-sws-jira
@mariannuar @cienvaras @sethprime @codechefmarc @joegl
11.6.1
1cf65f3 
* 11.6.1

* Update lock file.

* SHS-5911: Add indicator of 3rd level shortcut menu (#1681)

* SHS-5911: Add indicator of 3rd level shortcut menu.

* fix(shs-5912): change layout of ckeditor styles dropdown list (#1688)

Co-authored-by: joegl <20383-joegl@users.noreply.drupalcode.org>

* SHS:5892: Site managers can perform actions on user accounts that don't make sense with SSO (#1682)

* feat(shs-5892): remove actions from people view

* feat(shs-5892): remove elements from used edit form

* fix(shs-5892): fix issues in user edit form alter

* fix(shs-5892): remove delete actions only for non admin users

* Updated dependencies

* fix(shs-5911): use absolute path for image url to prevent error when drupal aggregates image (#1693)

* HSD8-1700: Increase Tugboat Max Allowed Packet size to 512MB. (#1695)

Co-authored-by: Seth Hendrick <32778-ponies@users.noreply.drupalcode.org>

* SHS-5808: Uninstall Webform module (#1625)

* SHS-5905: Rework social media footer (#1662)

* feat(SHS-5905): Recreate social media block as a custom block plugin

* feat(SHS-5905): Add composer.lock

* feat(SHS-5905): Enable multivalue form element module

* feat(SHS-5905): Add update hook for permissions change

* fix(SHS-5905): Fix error for default config and add cache context for user

* fix(SHS-5905): Contextual menu still not rendering on Tugboat for non-admins

* fix(SHS-5905): Fix attached library for contextual menu

* fix(SHS-5909): Strict checking of the array seemed to fix the contextual links on local

* fix(SHS-5905): Remove strict checking

* fix(SHS-5905): Remove old permissions before adding social media block permissions

* fix(SHS-5905): Linting fixes

* chore(SHS-5905): WIP TEST ONLY - see if removing the code block in the profile works on tugboat

* fix(SHS-5905): Fix contextual menu for non-admins

* feat(SHS-5905): Remove permission update hook and add dependency on one in profile

* feat(shs-5906): icon logic, templates and styles for social media footer block (#1673)

* chore(SHS-5905): Temp remove code to test other contextual menus

* feat(SHS-5905): Add custom contextual link

* fix(SHS-5905): Get contextual links working (finally) for Social Media block

* fix(shs-5905): fixes in social media block

* fix(shs-5905): replace multivalue_form_element with custom version in social media block

* fix(shs-5905): remove multivalue_form_element module

* fix(shs-5905): update social media block links help text

* fix(shs-5905): social media footer block fixes

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* Update hook to delete webform submissions

* SHS-5958: Bug: Inconsistent "Add Above" feature (#1692)

* fix(SHS-5958): Fix issue with paragraphs features to allow add buttons on non gin/claro themes

* feat(SHS-5958): Add config and update hook to allow add paragraphs in between

* refactor(SHS-5958): Change how we are updating the add in between to config

* test(SHS-5958): Update test to refelect new buttons

* test(SHS-5958): Update testPostCard test for new add in between buttons

* test(SHS-5958): Update other tests for new add in between buttons

* test(SHS-5958): Add a wait in test to make sure JS add in between buttons load

* test(SHS-5958): Fix photo album test - photo album can come before or after text component, making tests work sometimes but not all the time

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fixes in tests

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix private page tests

* chore(SHS-5958): Remove unnecessary layout builder config

* chore(SHS-5958): Revert hidden layout builder layout

* chore(SHS-5958): Revert composer.lock to 11.6.1 version

---------

Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>

* Removed unintended underscore in update hook name

* fixup update function name

* HSD8-1707: Removed edit button from default people view to resolve button display to anonymous users. (#1701)

* SHS-5904: Add new "log out" block to existing sites (#1696)

* HSD8-1664: Updated PR template (#1685)

* Updated PR template.

* Updated sanitiztion line.

* dropped ready for review title. added review tasks heading.

---------

Co-authored-by: joegl <20383-joegl@users.noreply.drupalcode.org>

* Revoke any webform permissions before uninstall module

* Removed assert_options from settings files

* HSD8-1702: delete mediterraneanstudies

---------

Co-authored-by: Github Actions <sws-developers@lists.stanford.edu>
Co-authored-by: joegl <20383-joegl@users.noreply.drupalcode.org>
Co-authored-by: Mariana Núñez <48533432+mariannuar@users.noreply.github.com>
Co-authored-by: Andrés Díaz Soto <andres.diaz.soto@gmail.com>
Co-authored-by: Mike Decker <pookmish@stanford.edu>
Co-authored-by: Seth <sethprime@users.noreply.github.com>
Co-authored-by: Seth Hendrick <32778-ponies@users.noreply.drupalcode.org>
Co-authored-by: Marc Berger <107938318+codechefmarc@users.noreply.github.com>
Co-authored-by: Joe Gilliland-Lloyd <6943710+joegl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pookmish pookmish pookmish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethprime @ahughes3 @pookmish