Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5995: Bulk add/remove roles incorrectly labels "Developer" as "Administrator" #1708

Merged
merged 2 commits into from
Jan 13, 2025
Merged

SHS-5995: Bulk add/remove roles incorrectly labels "Developer" as "Administrator" #1708

merged 2 commits into from
Jan 13, 2025

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Jan 7, 2025 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Changes the label of the system actions for adding and removing the "Administrator" role to match the label of the actual role name - Developer.

Need Review By (Date)

2025-01-08

Urgency

low

Steps to Test

  1. Login to the site as a developer
  2. Visit the Manage User Permissions page at /admin/users
  3. Select a few users with the checkboxes
  4. At the bottom, next to "Action", click on the select list
  5. Verify that the actions listed are changes from "Administrator" to "Developer"
  6. Verify that the action still does what it says it will do by clicking "Apply to selected items"

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat January 7, 2025 01:42 Destroyed
@codechefmarc codechefmarc requested a review from cienvaras January 7, 2025 01:43
@codechefmarc codechefmarc self-assigned this Jan 7, 2025
@codechefmarc codechefmarc marked this pull request as ready for review January 7, 2025 02:00
cienvaras
cienvaras approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc LGTM! 🚀

@ahughes3 Ready for you to review.

@cienvaras cienvaras requested a review from ahughes3 January 7, 2025 22:00
@cienvaras cienvaras assigned ahughes3 and unassigned codechefmarc Jan 7, 2025
Base automatically changed from 11.6.1-release to develop January 8, 2025 16:39
@ahughes3 ahughes3 assigned pookmish and unassigned ahughes3 Jan 13, 2025
@ahughes3 ahughes3 temporarily deployed to Tugboat January 13, 2025 19:51 Destroyed
ahughes3
ahughes3 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pookmish pookmish changed the base branch from develop to 11.6.3-release January 13, 2025 20:13
@pookmish pookmish enabled auto-merge (squash) January 13, 2025 20:14
@pookmish pookmish merged commit e80dc37 into 11.6.3-release Jan 13, 2025
17 of 18 checks passed
@pookmish pookmish deleted the SHS-5995--change-action-label branch January 13, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahughes3 ahughes3 ahughes3 approved these changes

@cienvaras cienvaras cienvaras approved these changes

@pookmish pookmish pookmish approved these changes

@sethprime sethprime Awaiting requested review from sethprime

Assignees

@pookmish pookmish

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codechefmarc @ahughes3 @cienvaras @pookmish